Skip to content

Commit daa93c0

Browse files
committed
fix(auth): signal auth_completed when client secrets check fails
Without this signal, the CLI blocks for 5 minutes (timeout) instead of immediately reporting the missing credentials error. Closes CodeRabbit review on PR taylorwilsdon#505.
1 parent 3bf016a commit daa93c0

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

auth/oauth_callback_server.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ async def oauth_callback(request: Request):
8282
# Check if we have credentials available (environment variables or file)
8383
error_message = check_client_secrets()
8484
if error_message:
85+
self.auth_result = {"success": False, "user_id": None, "error": error_message}
86+
self.auth_completed.set()
8587
return create_server_error_response(error_message)
8688

8789
logger.info(

0 commit comments

Comments
 (0)