fix: API compliance fixes for v2.0.3

- update_test_case: inject id into PATCH body (required by Allure API)
- manual_scenario: type ScenarioDto with required type discriminator per spec
- add_test_case_defect: fix endpoint POST /testcase/{id}/defect/{defectId}
- remove_test_case_members: replace DELETE /members with POST bulk/member/remove
- resolve_test_result / bulk_resolve: add required status field
- remove update_launch_environment (PUT /launch/{id}/env not in spec)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: MimoJanra

CHANGELOG.md

@@ -7,6 +7,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.0.3] - 2026-06-01 - API Compliance Fixes
+
+### Fixed
+
+- **`update_test_case` — `id` missing from request body** — `PATCH /api/testcase/{id}` requires the test case ID both in the URL path and in the JSON body. The body field was absent, causing the API to reject or misroute update requests.
+
+- **`update_test_case` — scenario steps lacked required `type` discriminator** — The Allure API uses a polymorphic step schema (`ScenarioStepDto`) with a required `type` field (`"body"` or `"expected"`). Steps were sent without this field, so the API could not determine the step variant. The `manual_scenario` field is now typed as `ScenarioDto{Steps []ScenarioStepDto}` with `type` enforced. Tool description and schema updated to make the step format explicit.
+
+- **`add_test_case_defect` — wrong endpoint** — was calling `POST /api/testcase/{id}/defect` (GET-only in spec). Corrected to `POST /api/testcase/{testCaseId}/defect/{defectId}` with no request body.
+
+- **`remove_test_case_members` — wrong endpoint and method** — was calling `DELETE /api/testcase/{id}/members` (not in spec). Replaced with `POST /api/testcase/bulk/member/remove` using the correct `{ids, selection}` body. Tool schema updated to require `project_id` (needed for the `selection` object).
+
+- **`resolve_test_result` — missing required `status` field** — `POST /api/testresult/{id}/resolve` requires a `status` body (`failed`, `broken`, `passed`, `skipped`, `unknown`). Was sending no body. Both the client method and tool schema now require `status`.
+
+- **`bulk_resolve_test_results` — missing required `status` field** — `POST /api/testresult/bulk/resolve` requires `status` alongside `selection`. The `TestResultBulkResolveDto` struct and tool schema updated accordingly.
+
+### Removed
+
+- **`update_launch_environment`** — `PUT /api/launch/{id}/env` does not exist in the Allure TestOps API (spec defines only `GET` on this path). Tool and client method removed to prevent silent failures.
+
 ## [2.0.2] - 2026-06-01 - Tool Discovery & Test Case Management
 
 ### Fixed

internal/adapters/allure/client.go

@@ -823,6 +823,7 @@ func (c *Client) CreateTestCase(ctx context.Context, projectID int64, name, desc
 }
 
 func (c *Client) UpdateTestCase(ctx context.Context, testCaseID int64, req UpdateTestCaseRequest) error {
+	req.ID = testCaseID
 	body, err := json.Marshal(req)
 	if err != nil {
 		return fmt.Errorf("marshal request: %w", err)
@@ -2174,13 +2175,14 @@ func (c *Client) BulkUnmuteTestResults(ctx context.Context, launchID int64, test
 	return nil
 }
 
-func (c *Client) BulkResolveTestResults(ctx context.Context, launchID int64, testResultIDs []int64) error {
+func (c *Client) BulkResolveTestResults(ctx context.Context, launchID int64, testResultIDs []int64, status string) error {
 	selection := TestResultTreeSelectionDto{
 		LaunchID:     launchID,
 		LeafsInclude: testResultIDs,
 	}
 	body, err := json.Marshal(TestResultBulkResolveDto{
 		Selection: selection,
+		Status:    status,
 	})
 	if err != nil {
 		return fmt.Errorf("marshal request: %w", err)
@@ -2354,8 +2356,12 @@ func (c *Client) CopyLaunch(ctx context.Context, launchID int64) (*LaunchRespons
 	return &result, nil
 }
 
-func (c *Client) ResolveTestResult(ctx context.Context, testResultID int64) error {
-	httpReq, err := http.NewRequestWithContext(ctx, http.MethodPost, c.url(fmt.Sprintf("/api/testresult/%d/resolve", testResultID)), nil)
+func (c *Client) ResolveTestResult(ctx context.Context, testResultID int64, status string) error {
+	body, err := json.Marshal(map[string]any{"status": status})
+	if err != nil {
+		return fmt.Errorf("marshal request: %w", err)
+	}
+	httpReq, err := http.NewRequestWithContext(ctx, http.MethodPost, c.url(fmt.Sprintf("/api/testresult/%d/resolve", testResultID)), bytes.NewBuffer(body))
 	if err != nil {
 		return fmt.Errorf("create request: %w", err)
 	}
@@ -2428,34 +2434,6 @@ func (c *Client) GetLaunchEnvironment(ctx context.Context, launchID int64) (map[
 	return result, nil
 }
 
-func (c *Client) UpdateLaunchEnvironment(ctx context.Context, launchID int64, env map[string]any) error {
-	body, err := json.Marshal(env)
-	if err != nil {
-		return fmt.Errorf("marshal request: %w", err)
-	}
-
-	httpReq, err := http.NewRequestWithContext(ctx, http.MethodPut, c.url(fmt.Sprintf("/api/launch/%d/env", launchID)), bytes.NewBuffer(body))
-	if err != nil {
-		return fmt.Errorf("create request: %w", err)
-	}
-	if err := c.setAuthHeader(ctx, httpReq); err != nil {
-		return fmt.Errorf("set auth: %w", err)
-	}
-	httpReq.Header.Set("Content-Type", "application/json")
-
-	resp, err := c.httpClient.Do(httpReq)
-	if err != nil {
-		return fmt.Errorf("http request: %w", err)
-	}
-	defer resp.Body.Close()
-
-	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNoContent {
-		return errFromResponse(resp)
-	}
-
-	return nil
-}
-
 func (c *Client) GetTestCaseHistory(ctx context.Context, testCaseID int64, page, size int) (map[string]any, error) {
 	url := fmt.Sprintf("/api/testcase/%d/history?page=%d&size=%d", testCaseID, page, size)
 	httpReq, err := http.NewRequestWithContext(ctx, http.MethodGet, c.url(url), nil)
@@ -2582,21 +2560,13 @@ func (c *Client) MergeLaunches(ctx context.Context, launchIDs []int64, launchNam
 }
 
 func (c *Client) AddTestCaseDefect(ctx context.Context, testCaseID, defectID int64) error {
-	body, err := json.Marshal(map[string]any{
-		"defectId": defectID,
-	})
-	if err != nil {
-		return fmt.Errorf("marshal request: %w", err)
-	}
-
-	httpReq, err := http.NewRequestWithContext(ctx, http.MethodPost, c.url(fmt.Sprintf("/api/testcase/%d/defect", testCaseID)), bytes.NewBuffer(body))
+	httpReq, err := http.NewRequestWithContext(ctx, http.MethodPost, c.url(fmt.Sprintf("/api/testcase/%d/defect/%d", testCaseID, defectID)), nil)
 	if err != nil {
 		return fmt.Errorf("create request: %w", err)
 	}
 	if err := c.setAuthHeader(ctx, httpReq); err != nil {
 		return fmt.Errorf("set auth: %w", err)
 	}
-	httpReq.Header.Set("Content-Type", "application/json")
 
 	resp, err := c.httpClient.Do(httpReq)
 	if err != nil {
@@ -2689,34 +2659,14 @@ func (c *Client) AddTestCaseMembers(ctx context.Context, testCaseID int64, membe
 	return nil
 }
 
-func (c *Client) RemoveTestCaseMembers(ctx context.Context, testCaseID int64, memberIDs []int64) error {
-	body, err := json.Marshal(map[string]any{
-		"memberIds": memberIDs,
+func (c *Client) RemoveTestCaseMembers(ctx context.Context, projectID, testCaseID int64, memberIDs []int64) error {
+	return c.bulkPost(ctx, "/api/testcase/bulk/member/remove", map[string]any{
+		"ids": memberIDs,
+		"selection": TestCaseTreeSelectionDto{
+			ProjectID:    projectID,
+			LeafsInclude: []int64{testCaseID},
+		},
 	})
-	if err != nil {
-		return fmt.Errorf("marshal request: %w", err)
-	}
-
-	httpReq, err := http.NewRequestWithContext(ctx, http.MethodDelete, c.url(fmt.Sprintf("/api/testcase/%d/members", testCaseID)), bytes.NewBuffer(body))
-	if err != nil {
-		return fmt.Errorf("create request: %w", err)
-	}
-	if err := c.setAuthHeader(ctx, httpReq); err != nil {
-		return fmt.Errorf("set auth: %w", err)
-	}
-	httpReq.Header.Set("Content-Type", "application/json")
-
-	resp, err := c.httpClient.Do(httpReq)
-	if err != nil {
-		return fmt.Errorf("http request: %w", err)
-	}
-	defer resp.Body.Close()
-
-	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNoContent {
-		return errFromResponse(resp)
-	}
-
-	return nil
 }
 
 // GetTestCaseExternalLinks returns the external URL links attached to a test case.

internal/adapters/allure/models.go

@@ -418,6 +418,7 @@ type CreateTestCaseRequest struct {
 
 // UpdateTestCaseRequest maps TestCasePatchV2Dto.
 type UpdateTestCaseRequest struct {
+	ID             int64                       `json:"id,omitempty"`
 	Name           string                      `json:"name,omitempty"`
 	Description    string                      `json:"description,omitempty"`
 	FullName       string                      `json:"fullName,omitempty"`
@@ -432,10 +433,23 @@ type UpdateTestCaseRequest struct {
 	Tags           []TestTagDto                `json:"tags,omitempty"`
 	Members        []MemberDto                 `json:"members,omitempty"`
 	Links          []ExternalLinkDto           `json:"links,omitempty"`
-	Scenario       map[string]any              `json:"scenario,omitempty"`
+	Scenario       *ScenarioDto                `json:"scenario,omitempty"`
 	CustomFields   []CustomFieldValueWithCfDto `json:"customFields,omitempty"`
 }
 
+// ScenarioDto is the top-level scenario object used in PATCH /api/testcase/{id}.
+type ScenarioDto struct {
+	Steps []ScenarioStepDto `json:"steps"`
+}
+
+// ScenarioStepDto represents a single manual step inside a scenario.
+// Type is required by the API discriminator: use "body" for a regular step,
+// "expected" for an expected-result entry.
+type ScenarioStepDto struct {
+	Type string `json:"type"`
+	Body string `json:"body,omitempty"`
+}
+
 // ── Shared DTOs ───────────────────────────────────────────────────────────────
 
 type ExternalLinkDto struct {
@@ -667,6 +681,7 @@ type TestResultBulkMuteDto struct {
 
 type TestResultBulkResolveDto struct {
 	Selection TestResultTreeSelectionDto `json:"selection"`
+	Status    string                     `json:"status"`
 	Issues    []interface{}              `json:"issues,omitempty"`
 }
 

internal/tools/registry_test.go

@@ -72,7 +72,6 @@ func TestRegistry_HasExpectedTools(t *testing.T) {
 		"resolve_test_result",
 		"unmute_test_result",
 		"get_launch_environment",
-		"update_launch_environment",
 		"get_test_case_history",
 		"get_launch_defects",
 		"get_test_case_defects",
@@ -150,8 +149,8 @@ func TestRegistry_HasExpectedTools(t *testing.T) {
 	has_search := r.GetTool("search_testops_operations") != nil
 	has_execute := r.GetTool("execute_testops_operation") != nil
 
-	// Expected count: 110 base tools + 2 OpenAPI tools (if spec found)
-	expected_count := 110
+	// Expected count: 109 base tools + 2 OpenAPI tools (if spec found)
+	expected_count := 109
 	if has_search && has_execute {
 		expected_count = 112
 	}

internal/tools/tools_bulk.go

@@ -238,8 +238,13 @@ func (r *Registry) registerBulkTools() {
 					},
 					"description": "Test result IDs",
 				},
+				"status": map[string]any{
+					"type":        "string",
+					"enum":        []string{"failed", "broken", "passed", "skipped", "unknown"},
+					"description": "Resolution status to set on all results",
+				},
 			},
-			"required": []string{"launch_id", "test_result_ids"},
+			"required": []string{"launch_id", "test_result_ids", "status"},
 		},
 		Handler: Typed(r.bulkResolveTestResults),
 	})
@@ -1003,6 +1008,7 @@ func (r *Registry) bulkUnmuteTestResults(ctx context.Context, args bulkUnmuteTes
 type bulkResolveTestResultsArgs struct {
 	LaunchID      int64   `json:"launch_id"`
 	TestResultIDs []int64 `json:"test_result_ids"`
+	Status        string  `json:"status"`
 }
 
 func (r *Registry) bulkResolveTestResults(ctx context.Context, args bulkResolveTestResultsArgs) (any, error) {
@@ -1012,10 +1018,13 @@ func (r *Registry) bulkResolveTestResults(ctx context.Context, args bulkResolveT
 	if len(args.TestResultIDs) == 0 {
 		return nil, fmt.Errorf("test_result_ids must not be empty")
 	}
+	if args.Status == "" {
+		return nil, fmt.Errorf("status is required")
+	}
 
 	r.logger.Info("bulk resolving test results", map[string]any{"launch_id": args.LaunchID, "count": len(args.TestResultIDs)})
 
-	if err := r.allure.BulkResolveTestResults(ctx, args.LaunchID, args.TestResultIDs); err != nil {
+	if err := r.allure.BulkResolveTestResults(ctx, args.LaunchID, args.TestResultIDs, args.Status); err != nil {
 		r.logger.Error("bulk resolve test results", err, map[string]any{"launch_id": args.LaunchID})
 		return nil, fmt.Errorf("bulk resolve: %w", err)
 	}

internal/tools/tools_launches.go

@@ -150,26 +150,6 @@ func (r *Registry) registerLaunchTools() {
 		Handler: Typed(r.getLaunchEnvironment),
 	})
 
-	r.register(&Tool{
-		Name:        "update_launch_environment",
-		Description: "Update launch environment variables",
-		InputSchema: map[string]any{
-			"type": "object",
-			"properties": map[string]any{
-				"launch_id": map[string]any{
-					"type":        "integer",
-					"description": "Allure launch ID",
-				},
-				"environment": map[string]any{
-					"type":        "object",
-					"description": "Environment variables as key-value pairs",
-				},
-			},
-			"required": []string{"launch_id", "environment"},
-		},
-		Handler: Typed(r.updateLaunchEnvironment),
-	})
-
 	r.register(&Tool{
 		Name:        "copy_launch",
 		Description: "Copy/duplicate a launch",
@@ -532,29 +512,6 @@ func (r *Registry) getLaunchEnvironment(ctx context.Context, args getLaunchEnvir
 	return map[string]any{"environment": env}, nil
 }
 
-type updateLaunchEnvironmentArgs struct {
-	LaunchID    int64          `json:"launch_id"`
-	Environment map[string]any `json:"environment"`
-}
-
-func (r *Registry) updateLaunchEnvironment(ctx context.Context, args updateLaunchEnvironmentArgs) (any, error) {
-	if args.LaunchID <= 0 {
-		return nil, fmt.Errorf("launch_id must be positive")
-	}
-	if len(args.Environment) == 0 {
-		return nil, fmt.Errorf("environment must not be empty")
-	}
-
-	r.logger.Info("updating launch environment", map[string]any{"launch_id": args.LaunchID})
-
-	if err := r.allure.UpdateLaunchEnvironment(ctx, args.LaunchID, args.Environment); err != nil {
-		r.logger.Error("update launch environment", err, map[string]any{"launch_id": args.LaunchID})
-		return nil, fmt.Errorf("update launch environment: %w", err)
-	}
-
-	return map[string]any{"status": "updated"}, nil
-}
-
 type copyLaunchArgs struct {
 	LaunchID int64 `json:"launch_id"`
 }

internal/tools/tools_relations.go

@@ -123,6 +123,10 @@ func (r *Registry) registerRelationTools() {
 		InputSchema: map[string]any{
 			"type": "object",
 			"properties": map[string]any{
+				"project_id": map[string]any{
+					"type":        "integer",
+					"description": "Allure project ID (required by the API)",
+				},
 				"test_case_id": map[string]any{
 					"type":        "integer",
 					"description": "Allure test case ID",
@@ -135,7 +139,7 @@ func (r *Registry) registerRelationTools() {
 					"description": "Member IDs to remove",
 				},
 			},
-			"required": []string{"test_case_id", "member_ids"},
+			"required": []string{"project_id", "test_case_id", "member_ids"},
 		},
 		Handler: Typed(r.removeTestCaseMembers),
 	})
@@ -345,11 +349,15 @@ func (r *Registry) addTestCaseMembers(ctx context.Context, args addTestCaseMembe
 }
 
 type removeTestCaseMembersArgs struct {
+	ProjectID  int64   `json:"project_id"`
 	TestCaseID int64   `json:"test_case_id"`
 	MemberIDs  []int64 `json:"member_ids"`
 }
 
 func (r *Registry) removeTestCaseMembers(ctx context.Context, args removeTestCaseMembersArgs) (any, error) {
+	if args.ProjectID <= 0 {
+		return nil, fmt.Errorf("project_id must be positive")
+	}
 	if args.TestCaseID <= 0 {
 		return nil, fmt.Errorf("test_case_id must be positive")
 	}
@@ -362,7 +370,7 @@ func (r *Registry) removeTestCaseMembers(ctx context.Context, args removeTestCas
 		"count":        len(args.MemberIDs),
 	})
 
-	if err := r.allure.RemoveTestCaseMembers(ctx, args.TestCaseID, args.MemberIDs); err != nil {
+	if err := r.allure.RemoveTestCaseMembers(ctx, args.ProjectID, args.TestCaseID, args.MemberIDs); err != nil {
 		r.logger.Error("remove test case members", err, map[string]any{"test_case_id": args.TestCaseID})
 		return nil, fmt.Errorf("remove test case members: %w", err)
 	}