Skip to content

[ALFMOB-356] Rename Android applicationId and Kotlin packages to com.mindera.alfie#16

Merged
hoangnhatdrk merged 5 commits into
mainfrom
feat/ALFMOB-356
May 20, 2026
Merged

[ALFMOB-356] Rename Android applicationId and Kotlin packages to com.mindera.alfie#16
hoangnhatdrk merged 5 commits into
mainfrom
feat/ALFMOB-356

Conversation

@amccall-mindera
Copy link
Copy Markdown
Contributor

@amccall-mindera amccall-mindera commented May 14, 2026

Summary

Aligns the Android app with the cross-platform identifier strategy agreed on 2026-05-14: native apps share the com.mindera.alfie prefix with iOS. Resolves ALFMOB-356 (blocked by ALFMOB-354).

Changes

  • applicationId: au.com.alfie.ecommcom.mindera.alfie (release variant).
  • .debug / .beta applicationIdSuffix removed: all three variants now share com.mindera.alfie. The BETA build type and Environment.PreProd binding still exist and will be removed under ALFMOB-357, which can now be closed if no further cleanup is needed.
  • Kotlin packages: au.com.alfie.ecomm.*com.mindera.alfie.* across all modules.
  • Module namespaces: convention-plugin namespaces rewritten; Apollo generated package now com.mindera.alfie.graphql; proto java_package updated.
  • Signing: release variant now explicitly wires signingConfig = signingConfigs.getByName(RELEASE.buildName). assembleRelease now requires keystore properties (keyAlias/keyPassword/storeFile/storePassword) — intentional.
  • getGitDetails (debug/operational/build.gradle.kts): made robust when the module's working directory is not the git repo root — uses rootProject.projectDir, ignores non-zero exit, falls back to "unknown".
  • Docs: .github/copilot-instructions.md path references updated.

Out of scope

  • iOS rename — already on com.mindera.alfie (ALFMOB-358 covers parallel iOS cleanup).
  • Flutter rename — ALFMOB-353.
  • Retiring old au.com.alfie.ecomm.* Firebase console entries — manual console step, no app shipped under those IDs.
  • Converging Android's GOOGLE_SERVICES_JSON GitHub Actions secret with the iOS git-secret approach — separate follow-up if desired.

Pre-merge checklist

  • Update GOOGLE_SERVICES_JSON GitHub Actions secret to the new com.mindera.alfie Firebase config — otherwise debug/beta CI deploys will write a stale google-services.json and fail / mis-report.

Acceptance criteria

  • All applicationId references and Kotlin package declarations use com.mindera.alfie.*.
  • Build succeeds across debug / beta / release variants.
  • All tests pass.
  • Firebase reports events under the new applicationId.
  • No lingering au.com.alfie.ecomm references in source, gradle, manifest, or CI config.

Test plan

  • ./gradlew assembleDebug assembleBeta assembleRelease
  • ./gradlew test
  • ./gradlew lint detekt
  • Install debug build on device; verify Firebase Analytics DebugView shows events under com.mindera.alfie.

Verification Agent and others added 3 commits May 14, 2026 23:05
Align Android applicationId and Kotlin packages with the cross-platform
identifier strategy agreed on 2026-05-14. Native apps share the
com.mindera.alfie prefix with iOS.

- applicationId: au.com.alfie.ecomm -> com.mindera.alfie (debug/beta/release)
- Kotlin packages renamed across app, core, data, network, domain, feature,
  buildconvention modules
- Manifests, gradle namespaces, ProGuard rules updated
- google-services.json refreshed with com.mindera.alfie registration
- Release build wires signingConfig; getGitDetails made robust when the
  module's working dir is not the git root
Self-review round 1: six stale au/com/alfie/ecomm path references in
.github/copilot-instructions.md missed by the bulk rename.
Brings in ALFMOB-83 Wishlist Functionality (#13). New files added on
main under au/com/alfie/ecomm/ have been moved to com/mindera/alfie/
and re-packaged to keep this branch's rename consistent.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@amccall-mindera amccall-mindera marked this pull request as ready for review May 19, 2026 15:31
Copilot AI review requested due to automatic review settings May 19, 2026 15:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Verification Agent and others added 2 commits May 19, 2026 17:11
The com.mindera.alfie.* prefix sorts after com.google.*, com.apollographql.*,
com.bumptech.*, and com.ramcosta.*, whereas the old au.com.alfie.ecomm.*
sorted before all of them. Reorder imports in 34 files so detekt's
ImportOrdering rule passes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
All build variants now share applicationId com.mindera.alfie, so debug and
beta deploy workflows both target the same Firebase app. Replace the
per-variant FIREBASE_APP_ID_DEBUG and FIREBASE_APP_ID_BETA secrets with a
single FIREBASE_APP_ID. The old secrets can be deleted after this lands.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@hoangnhatdrk hoangnhatdrk added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 9202c30 May 20, 2026
3 checks passed
@amccall-mindera amccall-mindera deleted the feat/ALFMOB-356 branch May 20, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants