Skip to content

ci: restore keystore decoding step for beta signing#18

Merged
amccall-mindera merged 2 commits into
mainfrom
ci/restore-keystore-signing
May 20, 2026
Merged

ci: restore keystore decoding step for beta signing#18
amccall-mindera merged 2 commits into
mainfrom
ci/restore-keystore-signing

Conversation

@amccall-mindera
Copy link
Copy Markdown
Contributor

@amccall-mindera amccall-mindera commented May 20, 2026

Summary

  • Adds the missing step to deploy_beta.yml that materializes the signing keystore at $HOME/app/alfie.keystore and exports the password/alias env vars consumed by fastlane/Fastfile's run_build_beta lane.
  • Without this, :app:validateSigningBeta fails on main with Keystore file '/home/runner/app/alfie.keystore' not found for signing config 'externalOverride' (see run 26142794217).

Required secrets

Before merging, ensure these are configured on the repo (Settings → Secrets and variables → Actions):

  • ANDROID_KEYSTORE_BASE64base64 -i alfie.keystore
  • ANDROID_KEYSTORE_PASSWORD
  • ANDROID_KEYSTORE_ALIAS
  • ANDROID_KEYSTORE_PRIVATE_KEY_PASSWORD (PKCS12 keystore — same value as the store password)

Test plan

  • All four secrets are present in repo settings
  • After merge, the next push to main runs deploy_beta.yml and :app:validateSigningBeta passes
  • Fastlane uploads a signed beta build to Firebase App Distribution

🤖 Generated with Claude Code

Adds the step that materializes the signing keystore from the
ANDROID_KEYSTORE_BASE64 secret to $HOME/app/alfie.keystore and exports
the password/alias env vars that fastlane's run_build_beta lane
consumes. Without this, :app:validateSigningBeta fails on main with
"Keystore file '/home/runner/app/alfie.keystore' not found".

Requires the following repo secrets to be configured:
- ANDROID_KEYSTORE_BASE64
- ANDROID_KEYSTORE_PASSWORD
- ANDROID_KEYSTORE_ALIAS
- ANDROID_KEYSTORE_PRIVATE_KEY_PASSWORD

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 20, 2026 12:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the missing keystore materialization step in the deploy_beta.yml GitHub Actions workflow so Fastlane’s run_build_beta lane can find the signing keystore at $HOME/app/alfie.keystore and read the required signing env vars.

Changes:

  • Add a workflow step to decode ANDROID_KEYSTORE_BASE64 into $HOME/app/alfie.keystore.
  • Export keystore password/alias/private key password variables for subsequent Fastlane execution.

Comment thread .github/workflows/deploy_beta.yml
Comment thread .github/workflows/deploy_beta.yml Outdated
Addresses PR feedback:
- Restrict keystore file permissions so the private key isn't
  world-readable on the runner.
- Pass keystore passwords via the Run Fastlane step's env instead
  of persisting them through $GITHUB_ENV, limiting blast radius.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@amccall-mindera amccall-mindera enabled auto-merge May 20, 2026 12:57
@amccall-mindera amccall-mindera merged commit 3327652 into main May 20, 2026
3 checks passed
@amccall-mindera amccall-mindera deleted the ci/restore-keystore-signing branch May 20, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants