Harmonise AI agent skills with cross-platform standard#64
Open
amccall-mindera wants to merge 6 commits intomainfrom
Open
Harmonise AI agent skills with cross-platform standard#64amccall-mindera wants to merge 6 commits intomainfrom
amccall-mindera wants to merge 6 commits intomainfrom
Conversation
- Rename ios-feature-developer -> feature-developer (standardised name) - Rename mobile-security-specialist -> security-specialist (standardised name) - Update all agent cross-references to use new standardised names - Add example query/fragment/converter pattern to graphql-specialist - Add acceptance criteria example + collaboration section to spec-writer - Add collaboration section to localization-specialist - Update AGENTS.md agent table to reflect new names and paths Agents are now named consistently across iOS, Android, and Flutter: feature-orchestrator, feature-developer, graphql-specialist, localization-specialist, security-specialist, spec-writer, testing-specialist Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes the iOS repo’s AI agent names/structure to match the cross-platform (iOS/Android/Flutter) naming standard, updating agent docs and cross-references accordingly.
Changes:
- Renamed
ios-feature-developer→feature-developerandmobile-security-specialist→security-specialist, updating references across agent docs andAGENTS.md. - Expanded agent guidance content (notably
graphql-specialistandspec-writer) and added collaboration sections to relevant agents. - Updated the
AGENTS.mdagent table and usage example to reflect the new standardized agent names.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Updates agent table + usage example to use standardized agent names. |
| .ai/agents/feature-developer.agent.md | Renames agent and updates description/collaboration references. |
| .ai/agents/feature-orchestrator.agent.md | Updates phase table/templates to reference renamed agents. |
| .ai/agents/graphql-specialist.agent.md | Adds an example query/fragment/converter pattern and updates collaboration references. |
| .ai/agents/localization-specialist.agent.md | Adds collaboration section referencing renamed agent. |
| .ai/agents/security-specialist.agent.md | Renames agent in frontmatter and updates collaboration reference. |
| .ai/agents/spec-writer.agent.md | Adds acceptance criteria example + collaboration section referencing renamed agent. |
| .ai/agents/testing-specialist.agent.md | Updates collaboration reference to renamed agent. |
Comment on lines
+43
to
+59
| **Fragment** (`Queries/Product/Fragments/ProductFragment.graphql`): | ||
| ```graphql | ||
| fragment ProductFragment on Product { | ||
| id | ||
| name | ||
| brand { ...BrandFragment } | ||
| price { ...PriceFragment } | ||
| } | ||
| ``` | ||
|
|
||
| **Converter** (`Core/Services/BFFService/Converters/ProductConverter.swift`): | ||
| ```swift | ||
| extension ProductFragment { | ||
| func toProduct() -> Product? { | ||
| Product(id: id, name: name, brand: brand?.toBrand(), price: price.toPrice()) | ||
| } | ||
| } |
Comment on lines
+34
to
+37
| **Query** (`Queries/Product/Queries.graphql`): | ||
| ```graphql | ||
| query GetProduct($productId: String!) { | ||
| product(productId: $productId) { |
- Fix query variable type: String! → ID! - Fix query field argument: productId → id - Fix paths to match actual CodeGen directory structure - Fix converter: ProductFragment → BFFGraphAPI.ProductFragment - Fix converter method: toProduct() → convertToProduct() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes AI agent naming and cross-references so the iOS agent system aligns with the shared cross-platform convention (iOS/Android/Flutter), while expanding a few agent guides with clearer examples and collaboration guidance.
Changes:
- Renamed agent identifiers to the standardized set (
feature-developer,security-specialist) and updated references across agent docs andAGENTS.md. - Expanded
graphql-specialistandspec-writerguidance with concrete examples/patterns. - Added/updated collaboration sections in multiple agent definitions.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Updates agent table + usage example to use standardized agent names. |
| .ai/agents/testing-specialist.agent.md | Updates collaboration references to feature-developer. |
| .ai/agents/spec-writer.agent.md | Adds acceptance criteria example + collaboration guidance. |
| .ai/agents/security-specialist.agent.md | Updates agent frontmatter name + collaboration reference. |
| .ai/agents/localization-specialist.agent.md | Adds collaboration section referencing standardized agent names. |
| .ai/agents/graphql-specialist.agent.md | Adds example query/fragment/converter pattern + updates collaboration reference. |
| .ai/agents/feature-orchestrator.agent.md | Updates phase table/templates to standardized agent names. |
| .ai/agents/feature-developer.agent.md | Updates agent frontmatter name/description + collaboration reference. |
Comments suppressed due to low confidence (1)
.ai/agents/security-specialist.agent.md:4
- The agent has been renamed to
security-specialist, but the opening sentence still describes the role as a “mobile security specialist”. Consider updating the intro text to use the new standardized agent name to avoid ambiguity when other agents/tooling quote it.
|
|
||
| ## Example Pattern | ||
|
|
||
| **Query** (`AlfieKit/Sources/BFFGraph/CodeGen/Queries/Products/Queries.graphql`): |
| } | ||
| ``` | ||
|
|
||
| **Fragment** (`AlfieKit/Sources/BFFGraph/CodeGen/Queries/Products/Details/Fragments/ProductFragment.graphql`): |
| } | ||
| ``` | ||
|
|
||
| **Converter** (`Core/Services/BFFService/Converters/ProductFragment+Converter.swift`): |
Comment on lines
+53
to
+57
| **Converter** (`Core/Services/BFFService/Converters/ProductFragment+Converter.swift`): | ||
| ```swift | ||
| extension BFFGraphAPI.ProductFragment { | ||
| func convertToProduct() -> Product { | ||
| Product(id: id, name: name, brand: brand.fragments.brandFragment.convertToBrand()) |
| ``` | ||
| @mobile-security-specialist Audit [Feature Name]. | ||
| @security-specialist Audit [Feature Name]. | ||
| Files: AlfieKit/Sources/<Feature>/, Core/Services/<Feature>/ |
- graphql-specialist: fix workflow steps 1-3,5 and example pattern paths to include Alfie/AlfieKit/Sources/ prefix matching real layout - graphql-specialist: expand simplified converter snippet with required fields and add clarifying comment - feature-orchestrator: fix security audit phase paths to include Alfie/ prefix Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardises AI agent names and structure to be consistent across iOS, Android, and Flutter.
Changes
ios-feature-developer→feature-developermobile-security-specialist→security-specialistgraphql-specialistwith example query/fragment/converter patternspec-writerwith acceptance criteria example and collaboration sectionlocalization-specialistAGENTS.mdagent table to reflect new standardised namesAgent names (now identical across all 3 platforms)
feature-orchestrator,feature-developer,graphql-specialist,localization-specialist,security-specialist,spec-writer,testing-specialistAll agents in
.ai/agents/for tool-agnostic compatibility (GitHub Copilot, Claude, Cursor, etc.)