Skip to content

Commit 3852758

Browse files
committed
docs: Update changelog
fix: Implement task declaration in DI correctly
1 parent 5bcf7a2 commit 3852758

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ try to keep MAJOR changes in sync with Minecraft updates.
1616

1717
### Changed
1818

19-
- **Feature system** has been reworked as a DSL built around Koin for dependency injection
19+
- `idofront-features` has been reworked as minor extensions around our own dependency injection framework, docs should be published [here](https://docs.mineinabyss.com/dependencies)
2020
- **Config system** has been reworked to use a builder class that can then pick whether to decode a single file, directory, or multi-entry format which has been moved here from Geary
21-
- **SerializableItemStack** uses a new service for letting other plugins register custom item types instead of manually adding support for them
21+
- **SerializableItemStack** uses a new service for letting other plugins register custom item types instead of manually adding support for them. See `SerializableItemStackService.registerProvider`.
2222
- Brigadier **command api** internals reworked with much cleaner inside logic and fixes to expected behaviour from Brigadier
2323

2424
### Removed

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ creative = "1.11.14"
77
customblockdata = "1.2.1"
88
dataframe = "0.15.0"
99
dependencyversions = "0.52.0"
10-
dependencies-kt = "0.1.3-dev.0"
10+
dependencies-kt = "0.1.3-dev.1"
1111
dokka = "2.1.0"
1212
exposed = "1.0.0"
1313
fastutil = "8.5.18"

idofront-features/src/main/kotlin/com/mineinabyss/idofront/features/FeatureDSL.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ fun requirePlugins(vararg names: String) {
3535
}
3636

3737
fun MutableDI.task(job: Job) {
38-
val scope = get<CoroutineScope>()
39-
scope.launch { job.join() }
38+
addCloseable { job.cancel() }
4039
}
4140

4241
//fun MutableDI.commands(block: context(DICommandContext) RootIdoCommands.() -> Unit) = once {

settings.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,4 @@ val projects = listOf(
4646
"examples",
4747
)
4848

49-
include(projects)
49+
include(projects)

0 commit comments

Comments
 (0)