Bump OpenInv dependency up to at least 5.1.7 and therefor minimum Minecraft version to 1.21.1

This in turn lets us drop setting the Location of offline players who never played on the server before.
Openinv will safely set them to the spawn location of the server wherever that may be (com.lishid.openinv.internal.common.player.PlayerManager#spawnInDefaultWorld)
Note: OpenInv restructured its building process in the very same version. And currently isn't able to publish anything other than it's API automatically to a maven repo.
Internally everything we do access directly remains unchanged, so it's fine to keep the compile time version
Note: For future reference, a player .dat needs at least one tag, it doesn't need to be valid. However, older minecraft versions will keep junk data. So I opted for the player unused brain system. Any tag without impact will do, really. Adding a DataVersion tag potentially will run the DFU and may print messages in the console but also should be fine to use.

Author: FireInstall

README.md

@@ -6,10 +6,10 @@ Provided without any (implied) support nor warranty! (See [GPLv3 license](https:
 ## Requirements
 
 - At least Java 21
-- [Paper](https://papermc.io) Minecraft server software (tested on 1.20.6+, should be the same version on all synced
+- [Paper](https://papermc.io) Minecraft server software (tested on 1.21.1+, should be the same version on all synced
   servers)
 - [redis](https://redis.io) pub-sub
-- [OpenInv](https://github.com/jikoo/OpenInv) (optionally, for a more smooth experience)
+- [OpenInv 5.1.7+](https://github.com/jikoo/OpenInv) (optionally, for a more smooth experience)
 
 ## Setup
 

pom.xml

@@ -50,6 +50,12 @@
         <dependency>
             <groupId>com.lishid</groupId>
             <artifactId>openinvplugin</artifactId>
+            <!--
+            Note: currently there is a discrepancy between run and compile time version!
+            Since OpenInv isn't able to publish anything else than it's API to maven, we remain
+            on 5.1.1 to compile against.
+            However, runtime dependency has moved on to 5.1.7+!
+            -->
             <version>5.1.1</version>
             <scope>provided</scope>
         </dependency>

src/main/java/de/minebench/syncinv/SyncInv.java

@@ -19,16 +19,14 @@
 import de.minebench.syncinv.messenger.RedisMessenger;
 import de.minebench.syncinv.messenger.ServerMessenger;
 import lombok.Getter;
+import org.apache.maven.artifact.versioning.ComparableVersion;
 import org.bukkit.ChatColor;
 import org.bukkit.GameRule;
-import org.bukkit.Location;
 import org.bukkit.Material;
 import org.bukkit.OfflinePlayer;
 import org.bukkit.Sound;
 import org.bukkit.Statistic;
 import org.bukkit.World;
-import org.bukkit.WorldCreator;
-import org.bukkit.WorldType;
 import org.bukkit.advancement.Advancement;
 import org.bukkit.advancement.AdvancementProgress;
 import org.bukkit.command.Command;
@@ -169,11 +167,6 @@ public final class SyncInv extends JavaPlugin {
     // Unknown player storing
     private Function<GameProfile, OfflinePlayer> getOfflinePlayer = null;
     private Method methodGetHandle = null;
-    private Method methodSetPositionRaw;
-    private Field fieldYaw = null;
-    private Field fieldPitch = null;
-    private Method methodSetYaw = null;
-    private Method methodSetPitch = null;
 
     // Offline player health setting
     private Method methodSetHealth;
@@ -271,6 +264,14 @@ public void onEnable() {
         getServer().getMessenger().registerOutgoingPluginChannel(this, "BungeeCord");
         getCommand("syncinv").setExecutor(this);
         if (openInv != null) {
+            // ensure minimum OpenInv version is present.
+            if (storeUnknownPlayers && new ComparableVersion(openInv.getPluginMeta().getVersion()).compareTo(new ComparableVersion("5.1.7")) < 0) {
+                getLogger().severe(
+                    "Warning: You are using a not supported Version of OpenInv! " +
+                    "Please update to Version 5.1.7 or higher! " +
+                    "With the wrong version version present storing unknown players will fail!");
+            }
+
             OpenInvCommand openInvCommand = (OpenInvCommand) openInv.getCommand("openinv").getExecutor();
             CommandExecutor forwarding = (sender, command, label, args) -> {
                 if (sender instanceof Player && args.length > 0 && (!getMessenger().isAllowedToBeAlone() || !getMessenger().isAlone())) {
@@ -451,22 +452,6 @@ && getConfig().contains("sync-" + syncType.getKey(), true)) {
                 disableSync(SyncType.MAPS);
             }
         }
-
-        // Make sure the world "world" exists so that we can store unknown players without issues
-        if (storeUnknownPlayers && getServer().getWorld("world") == null && getConfig().getBoolean("create-world")) {
-            getLogger().log(Level.INFO, "No world with the name 'world' exists while 'store-unknown-players' is enabled. This world is needed for that functionality to work correctly, creating it... (can be disabled with 'create-world' in the config)");
-            World world = getServer().createWorld(new WorldCreator("world")
-                    .type(WorldType.FLAT)
-                    .generateStructures(false));
-            world.setAutoSave(false);
-            world.setViewDistance(2);
-            world.setKeepSpawnInMemory(false);
-            world.setGameRule(GameRule.DO_WEATHER_CYCLE, false);
-            world.setGameRule(GameRule.DO_MOB_SPAWNING, false);
-            world.setGameRule(GameRule.DO_FIRE_TICK, false);
-            world.setGameRule(GameRule.DO_DAYLIGHT_CYCLE, false);
-            world.setGameRule(GameRule.DISABLE_RAIDS, true);
-        }
     }
 
     public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
@@ -647,49 +632,6 @@ public void applyData(PlayerData data, Runnable finished) {
                     player = getOpenInv().loadPlayer(offlinePlayer);
                     if (player == null) {
                         logDebug("Unable to load player " + offlinePlayer.getName() + "/" + offlinePlayer.getUniqueId() + " data with OpenInv");
-                    } else if (createdNewFile) {
-                        try {
-                            if (methodGetHandle == null) {
-                                methodGetHandle = player.getClass().getMethod("getHandle");
-                            }
-                            Object entity = methodGetHandle.invoke(player);
-                            if (methodSetPositionRaw == null || (fieldYaw == null && methodSetYaw == null) || (fieldPitch == null || methodSetPitch == null)) {
-                                try {
-                                    // should be the "go-to" since 1.20.5+ for paper
-                                    methodSetPositionRaw = entity.getClass().getMethod("setPositionRaw", double.class, double.class, double.class);
-                                } catch (NoSuchMethodException e) {
-                                    // TODO: Better obfuscation support <-- use paper's userDev
-                                    // 1.18-1.18.2 was "e", would become "o" until 1.19.2 and is now (1.20.6 when not Moj-Mapped) "p"
-                                    methodSetPositionRaw = entity.getClass().getMethod("p", double.class, double.class, double.class);
-                                }
-                                try {
-                                    fieldYaw = entity.getClass().getField("yaw");
-                                    fieldPitch = entity.getClass().getField("pitch");
-                                } catch (NoSuchFieldException e) {
-                                    try {
-                                        methodSetYaw = entity.getClass().getMethod("setYRot", float.class);
-                                        methodSetPitch = entity.getClass().getMethod("setYRot", float.class);
-                                    } catch (NoSuchMethodException ignored) {}
-                                }
-                            }
-                            Location spawn = getServer().getWorlds().get(0).getSpawnLocation();
-                            methodSetPositionRaw.invoke(entity, spawn.getX(), spawn.getY(), spawn.getZ());
-                            if (fieldYaw != null) {
-                                fieldYaw.set(entity, spawn.getYaw());
-                            } else if (methodSetYaw != null) {
-                                methodSetYaw.invoke(entity, spawn.getYaw());
-                            }
-                            if (fieldPitch != null) {
-                                fieldPitch.set(entity, spawn.getPitch());
-                            } else if (methodSetPitch != null) {
-                                methodSetPitch.invoke(entity, spawn.getPitch());
-                            }
-                        } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
-                            getLogger().log(Level.WARNING, "Error while trying to set location of an unknown player. Disabling unknown player storage it!", e);
-                            storeUnknownPlayers = false;
-                            player = null;
-                            getOpenInv().unload(offlinePlayer);
-                        }
                     }
                 } else if (!getOpenInv().disableSaving() && getOpenInv().isPlayerLoaded(player.getUniqueId())) {
                     Player openInvLoadedPlayer = getOpenInv().loadPlayer(player);

src/main/resources/config.yml

@@ -38,10 +38,6 @@ sync-with-group-on-logout: true
 # breaks first join detection of other plugins
 store-unknown-players: true
 
-# Whether to create a missing 'world' world which is required
-# for unknown player storage to work
-create-world: true
-
 # The amount of seconds we should maximally wait for all servers to
 # respond to a query
 query-timeout: 15

src/main/resources/plugin.yml

@@ -1,6 +1,6 @@
 name: ${project.name}
 version: '${minecraft.plugin.version}'
-api-version: '1.20'
+api-version: '1.21.1'
 main: de.minebench.syncinv.SyncInv
 softdepend: [OpenInv]
 authors: [Phoenix616]