Skip to content

Commit d71878e

Browse files
committed
Quiet down the warning to one line on the task itself.
Disable signing ourselves because gradle injects code into our package at runtime and it breaks signatures.
1 parent d0ba2a2 commit d71878e

4 files changed

Lines changed: 5 additions & 8 deletions

File tree

.github/workflows/gradle_publish_on_push.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ jobs:
1818
- uses: actions/checkout@v3
1919
with:
2020
fetch-depth: 0
21-
- name: Set up JDK 17
21+
- name: Set up JDK 8
2222
uses: actions/setup-java@v2
2323
with:
24-
java-version: 17
24+
java-version: 8
2525
distribution: 'adopt'
2626
cache: gradle
2727
- name: Build and Publish

build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ plugins {
55
id 'java-gradle-plugin'
66
id 'eclipse'
77
id 'net.minecraftforge.gradleutils' version '2.0.11'
8-
id 'net.minecraftforge.gradlejarsigner' version '1.0.0'
98
}
109

1110
repositories {
@@ -15,7 +14,6 @@ repositories {
1514
group = 'net.minecraftforge'
1615
java.toolchain.languageVersion = JavaLanguageVersion.of(8)
1716
java.withSourcesJar()
18-
jarSigner.fromEnvironmentVariables()
1917

2018
license {
2119
header project.file('LICENSE-header.txt')
@@ -51,10 +49,9 @@ jar {
5149
'Implementation-Title': 'SimpleGradleJarSigner',
5250
'Implementation-Version': project.version,
5351
'Implementation-Vendor': 'Forge Development LLC'
54-
] as LinkedHashMap, 'net/minecraftforge/GradleJarSigner/')
52+
] as LinkedHashMap, 'net/minecraftforge/gradlejarsigner/')
5553
}
5654
}
57-
jarSigner.sign(jar)
5855

5956
publishing {
6057
publications {

src/main/java/net/minecraftforge/gradlejarsigner/GradleJarSignerExtension.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,5 @@ private void set(String key, Consumer<String> prop) {
8181
String data = System.getenv(key);
8282
if (data != null)
8383
prop.accept(data);
84-
else
85-
this.project.getLogger().warn("Missing " + key + " Environment Variable");
8684
}
8785
}

src/main/java/net/minecraftforge/gradlejarsigner/SignTask.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ private <T extends Task> void signSafe(T task) {
9898
try {
9999
if (hasEnoughInfo())
100100
this.sign(task);
101+
else
102+
task.getLogger().warn("Jar will be unsigned, missing key information");
101103
} catch (IOException e) {
102104
throw new RuntimeException(e);
103105
}

0 commit comments

Comments
 (0)