Don't eagerly kill failed decompile processes. Closes #20

LexManos · LexManos · commit 38d327f6c153 · 2026-03-03T18:24:23.000-08:00
diff --git a/src/main/java/net/minecraftforge/mcmaven/impl/util/ProcessUtils.java b/src/main/java/net/minecraftforge/mcmaven/impl/util/ProcessUtils.java
@@ -158,9 +158,11 @@ public static int runCommand(File workDir, Consumer<String> lines, ToIntFunction
                     if (logHandler != null && forcedExit == 0) {
                         forcedExit = logHandler.applyAsInt(line);
 
+                        /* We can't destroy the process here because we want to log everything. For some reason it doesn't finish logging if we do this.
                         // We don't want to exit here, because we want to log the rest of the output before exiting.
                         if (forcedExit != 0)
                             process.destroy();
+                        */
                     }
                 }
             } catch (IOException e) {

Original file line number	Diff line number	Diff line change
`@@ -158,9 +158,11 @@ public static int runCommand(File workDir, Consumer<String> lines, ToIntFunction`
`158`	`158`	`if (logHandler != null && forcedExit == 0) {`
`159`	`159`	`forcedExit = logHandler.applyAsInt(line);`
`160`	`160`
	`161`	`+ /* We can't destroy the process here because we want to log everything. For some reason it doesn't finish logging if we do this.`
`161`	`162`	`// We don't want to exit here, because we want to log the rest of the output before exiting.`
`162`	`163`	`if (forcedExit != 0)`
`163`	`164`	`process.destroy();`
	`165`	`+ */`
`164`	`166`	`}`
`165`	`167`	`}`
`166`	`168`	`} catch (IOException e) {`