Don't add mappings csv zip as dependency if we are not obfuscated.

Author: LexManos

src/main/java/net/minecraftforge/mcmaven/impl/repo/Repo.java

@@ -289,14 +289,19 @@ protected List<PendingArtifact> mappingArtifacts(File cache, Mappings mappings,
         var coords = mappings.getArtifact(side);
         var csvs = pending("Mappings Zip", mappings.getCsvZip(side), coords, false);
         var pom = pending("Mappings POM", simplePom(cache, coords), coords.withExtension("pom"), false);
+
+        if (outputJson != null) {
+            outputJson.put("mappings.csv.artifact", csvs.artifact()::toString);
+            outputJson.put("mappings.csv.file", csvs.task().filePathSupplier());
+        }
+
         // Just create the zip and pom for unobfuscated versions.
         if (!MCPConfigRepo.isObfuscated(side.getMCP().getMinecraftTasks().getVersion()))
             return List.of(csvs, pom);
+
         var m2o = pending("Mappings map2obf", mappings.getMapped2Obf(side), coords.withClassifier("map2obf").withExtension("tsrg.gz"), false);
         var m2s = pending("Mappings map2srg", mappings.getMapped2Srg(side), coords.withClassifier("map2srg").withExtension("tsrg.gz"), false);
         if (outputJson != null) {
-            outputJson.put("mappings.csv.artifact", csvs.artifact()::toString);
-            outputJson.put("mappings.csv.file", csvs.task().filePathSupplier());
             outputJson.put("mappings.obf.artifact", m2o.artifact()::toString);
             outputJson.put("mappings.obf.file", m2o.task().filePathSupplier());
             outputJson.put("mappings.srg.artifact", m2s.artifact()::toString);

src/main/java/net/minecraftforge/mcmaven/impl/repo/forge/ForgeRepo.java

@@ -28,6 +28,9 @@
 
 import javax.xml.parsers.ParserConfigurationException;
 import javax.xml.transform.TransformerException;
+
+import org.jetbrains.annotations.Nullable;
+
 import java.io.File;
 import java.io.FileOutputStream;
 import java.io.FileWriter;
@@ -152,7 +155,9 @@ private List<PendingArtifact> processV3(String version, Mappings mappings, Map<S
         var classesTask = new InjectTask(build, this.cache, name, patcher, recompile, mappings);
 
         var extraCoords = Artifact.from(Constants.MC_GROUP, Constants.MC_CLIENT + "-extra", patcher.getMCP().getName().getVersion());
-        var mappingCoords = mappings.getArtifact(joined);
+
+        // If we are not obfuscated, don't add the csv zip as a extra artifact
+        var mappingCoords = patcher.isObfuscated() ? mappings.getArtifact(joined) : null;
 
         var mappingArtifacts = mappingArtifacts(build, mappings, joined, outputJson);
 
@@ -270,15 +275,18 @@ private static Task metadata(File build, Patcher patcher) {
         });
     }
 
-    private static Task pom(File build, Patcher patcher, String version, Artifact clientExtra, Artifact mappings) {
+    private static Task pom(File build, Patcher patcher, String version, @Nullable Artifact clientExtra, @Nullable Artifact mappings) {
         return Task.named("pom[forge]", () -> {
             var output = new File(build, "forge.pom");
             var cache = Util.cache(output)
                 .addKnown("data", patcher.getDataHash())
-                .addKnown("extra", Util.replace(clientExtra, Object::toString))
-                .addKnown("mappings", Util.replace(mappings, Object::toString))
-                .addKnown("code-version", "1")
-                ;
+                .addKnown("code-version", "1");
+
+            if (clientExtra != null)
+                cache.addKnown("extra", clientExtra.toString());
+
+            if (mappings != null)
+                cache.addKnown("mappings", mappings.toString());
 
             if (Mavenizer.checkCache(output, cache))
                 return output;

src/main/java/net/minecraftforge/mcmaven/impl/repo/forge/Patcher.java

@@ -31,6 +31,7 @@
 import net.minecraftforge.mcmaven.impl.cache.Cache;
 import net.minecraftforge.mcmaven.impl.cache.MavenCache;
 import net.minecraftforge.mcmaven.impl.repo.mcpconfig.MCP;
+import net.minecraftforge.mcmaven.impl.repo.mcpconfig.MCPConfigRepo;
 import net.minecraftforge.mcmaven.impl.repo.mcpconfig.MCPSide;
 import net.minecraftforge.mcmaven.impl.util.Artifact;
 import net.minecraftforge.mcmaven.impl.util.Constants;
@@ -197,6 +198,14 @@ private void validateConfig() {
             throw except("Missing parent or mcp entry");
     }
 
+    /**
+     * @return Weither or not this patcher is for an obfuscated Minecraft version.
+     * AKA: 26.1+ For now this is based off Minecraft version, but in the future could be opt-in by a MCPConfig setting.
+     */
+    public boolean isObfuscated() {
+        return MCPConfigRepo.isObfuscated(getMCP().getMinecraftTasks().getVersion());
+    }
+
     /** @return The instance of MCP used to decompile the game */
     public MCP getMCP() {
         return this.mcp == null ? this.parent.getMCP() : this.mcp;