feat: Remove prd.json dependency

Author: MiniCodeMonkey

cmd/chief/main.go

@@ -93,7 +93,7 @@ func findAvailablePRD() string {
 
 	for _, entry := range entries {
 		if entry.IsDir() {
-			prdPath := filepath.Join(prdsDir, entry.Name(), "prd.json")
+			prdPath := filepath.Join(prdsDir, entry.Name(), "prd.md")
 			if _, err := os.Stat(prdPath); err == nil {
 				return prdPath
 			}
@@ -113,7 +113,7 @@ func listAvailablePRDs() []string {
 	var names []string
 	for _, entry := range entries {
 		if entry.IsDir() {
-			prdPath := filepath.Join(prdsDir, entry.Name(), "prd.json")
+			prdPath := filepath.Join(prdsDir, entry.Name(), "prd.md")
 			if _, err := os.Stat(prdPath); err == nil {
 				names = append(names, entry.Name())
 			}
@@ -241,11 +241,11 @@ func parseTUIFlags() *TUIOptions {
 			os.Exit(1)
 		default:
 			// Positional argument: PRD name or path
-			if strings.HasSuffix(arg, ".json") || strings.HasSuffix(arg, "/") {
+			if strings.HasSuffix(arg, ".md") || strings.HasSuffix(arg, ".json") || strings.HasSuffix(arg, "/") {
 				opts.PRDPath = arg
 			} else {
 				// Treat as PRD name
-				opts.PRDPath = fmt.Sprintf(".chief/prds/%s/prd.json", arg)
+				opts.PRDPath = fmt.Sprintf(".chief/prds/%s/prd.md", arg)
 			}
 		}
 	}
@@ -282,18 +282,11 @@ func runNew() {
 func runEdit() {
 	opts := cmd.EditOptions{}
 
-	// Parse arguments: chief edit [name] [--merge] [--force] [--agent X] [--agent-path X]
+	// Parse arguments: chief edit [name] [--agent X] [--agent-path X]
 	flagAgent, flagPath, remaining := parseAgentFlags(os.Args, 2)
 	for _, arg := range remaining {
-		switch {
-		case arg == "--merge":
-			opts.Merge = true
-		case arg == "--force":
-			opts.Force = true
-		default:
-			if opts.Name == "" && !strings.HasPrefix(arg, "-") {
-				opts.Name = arg
-			}
+		if opts.Name == "" && !strings.HasPrefix(arg, "-") {
+			opts.Name = arg
 		}
 	}
 
@@ -368,7 +361,7 @@ func runTUIWithOptions(opts *TUIOptions) {
 	// If no PRD specified, try to find one
 	if prdPath == "" {
 		// Try "main" first
-		mainPath := ".chief/prds/main/prd.json"
+		mainPath := ".chief/prds/main/prd.md"
 		if _, err := os.Stat(mainPath); err == nil {
 			prdPath = mainPath
 		} else {
@@ -411,30 +404,23 @@ func runTUIWithOptions(opts *TUIOptions) {
 			}
 
 			// Restart TUI with the new PRD
-			opts.PRDPath = fmt.Sprintf(".chief/prds/%s/prd.json", result.PRDName)
+			opts.PRDPath = fmt.Sprintf(".chief/prds/%s/prd.md", result.PRDName)
 			runTUIWithOptions(opts)
 			return
 		}
 	}
 
 	prdDir := filepath.Dir(prdPath)
 
-	// Check if prd.md is newer than prd.json and run conversion if needed
-	needsConvert, err := prd.NeedsConversion(prdDir)
-	if err != nil {
-		fmt.Printf("Warning: failed to check conversion status: %v\n", err)
-	} else if needsConvert {
-		fmt.Println("prd.md is newer than prd.json, running conversion...")
-		if err := cmd.RunConvertWithOptions(cmd.ConvertOptions{
-			PRDDir:   prdDir,
-			Merge:    opts.Merge,
-			Force:    opts.Force,
-			Provider: provider,
-		}); err != nil {
-			fmt.Printf("Error converting PRD: %v\n", err)
-			os.Exit(1)
+	// Auto-migrate: if prd.json exists alongside prd.md, migrate status
+	jsonPath := filepath.Join(prdDir, "prd.json")
+	if _, err := os.Stat(jsonPath); err == nil {
+		fmt.Println("Migrating status from prd.json to prd.md...")
+		if err := prd.MigrateFromJSON(prdDir); err != nil {
+			fmt.Printf("Warning: migration failed: %v\n", err)
+		} else {
+			fmt.Println("Migration complete (prd.json renamed to prd.json.bak).")
 		}
-		fmt.Println("Conversion complete.")
 	}
 
 	app, err := tui.NewAppWithOptions(prdPath, opts.MaxIterations, provider)
@@ -492,23 +478,21 @@ func runTUIWithOptions(opts *TUIOptions) {
 				os.Exit(1)
 			}
 			// Restart TUI with the new PRD
-			opts.PRDPath = fmt.Sprintf(".chief/prds/%s/prd.json", finalApp.PostExitPRD)
+			opts.PRDPath = fmt.Sprintf(".chief/prds/%s/prd.md", finalApp.PostExitPRD)
 			runTUIWithOptions(opts)
 
 		case tui.PostExitEdit:
 			// Run edit command then restart TUI
 			editOpts := cmd.EditOptions{
 				Name:     finalApp.PostExitPRD,
-				Merge:    opts.Merge,
-				Force:    opts.Force,
 				Provider: provider,
 			}
 			if err := cmd.RunEdit(editOpts); err != nil {
 				fmt.Fprintf(os.Stderr, "Error: %v\n", err)
 				os.Exit(1)
 			}
 			// Restart TUI with the edited PRD
-			opts.PRDPath = fmt.Sprintf(".chief/prds/%s/prd.json", finalApp.PostExitPRD)
+			opts.PRDPath = fmt.Sprintf(".chief/prds/%s/prd.md", finalApp.PostExitPRD)
 			runTUIWithOptions(opts)
 		}
 	}
@@ -518,7 +502,7 @@ func printHelp() {
 	fmt.Println(`Chief - Autonomous PRD Agent
 
 Usage:
-  chief [options] [<name>|<path/to/prd.json>]
+  chief [options] [<name>|<path/to/prd.md>]
   chief <command> [arguments]
 
 Commands:
@@ -545,13 +529,13 @@ Edit Options:
   --force                   Auto-overwrite on conversion conflicts
 
 Positional Arguments:
-  <name>                    PRD name (loads .chief/prds/<name>/prd.json)
-  <path/to/prd.json>        Direct path to a prd.json file
+  <name>                    PRD name (loads .chief/prds/<name>/prd.md)
+  <path/to/prd.md>        Direct path to a prd.md file
 
 Examples:
   chief                     Launch TUI with default PRD (.chief/prds/main/)
   chief auth                Launch TUI with named PRD (.chief/prds/auth/)
-  chief ./my-prd.json       Launch TUI with specific PRD file
+  chief ./my-prd.md       Launch TUI with specific PRD file
   chief -n 20               Launch with 20 max iterations
   chief --max-iterations=5 auth
                             Launch auth PRD with 5 max iterations

embed/convert_prompt.txt

@@ -16,19 +16,15 @@ var initPromptTemplate string
 //go:embed edit_prompt.txt
 var editPromptTemplate string
 
-//go:embed convert_prompt.txt
-var convertPromptTemplate string
-
 //go:embed detect_setup_prompt.txt
 var detectSetupPromptTemplate string
 
-// GetPrompt returns the agent prompt with the PRD path, progress path, and
+// GetPrompt returns the agent prompt with the progress path and
 // current story context substituted. The storyContext is the JSON of the
 // current story to work on, inlined directly into the prompt so that the
-// agent does not need to read the entire prd.json file.
-func GetPrompt(prdPath, progressPath, storyContext, storyID, storyTitle string) string {
-	result := strings.ReplaceAll(promptTemplate, "{{PRD_PATH}}", prdPath)
-	result = strings.ReplaceAll(result, "{{PROGRESS_PATH}}", progressPath)
+// agent does not need to read the entire prd.md file.
+func GetPrompt(progressPath, storyContext, storyID, storyTitle string) string {
+	result := strings.ReplaceAll(promptTemplate, "{{PROGRESS_PATH}}", progressPath)
 	result = strings.ReplaceAll(result, "{{STORY_CONTEXT}}", storyContext)
 	result = strings.ReplaceAll(result, "{{STORY_ID}}", storyID)
 	return strings.ReplaceAll(result, "{{STORY_TITLE}}", storyTitle)
@@ -48,14 +44,6 @@ func GetEditPrompt(prdDir string) string {
 	return strings.ReplaceAll(editPromptTemplate, "{{PRD_DIR}}", prdDir)
 }
 
-// GetConvertPrompt returns the PRD converter prompt with the file path and ID prefix substituted.
-// Claude reads the file itself using file-reading tools instead of receiving inlined content.
-// The idPrefix determines the story ID convention (e.g., "US" → US-001, "MFR" → MFR-001).
-func GetConvertPrompt(prdFilePath, idPrefix string) string {
-	result := strings.ReplaceAll(convertPromptTemplate, "{{PRD_FILE_PATH}}", prdFilePath)
-	return strings.ReplaceAll(result, "{{ID_PREFIX}}", idPrefix)
-}
-
 // GetDetectSetupPrompt returns the prompt for detecting project setup commands.
 func GetDetectSetupPrompt() string {
 	return detectSetupPromptTemplate

embed/embed.go

@@ -6,15 +6,11 @@ import (
 )
 
 func TestGetPrompt(t *testing.T) {
-	prdPath := "/path/to/prd.json"
 	progressPath := "/path/to/progress.md"
 	storyContext := `{"id":"US-001","title":"Test Story"}`
-	prompt := GetPrompt(prdPath, progressPath, storyContext, "US-001", "Test Story")
+	prompt := GetPrompt(progressPath, storyContext, "US-001", "Test Story")
 
 	// Verify all placeholders were substituted
-	if strings.Contains(prompt, "{{PRD_PATH}}") {
-		t.Error("Expected {{PRD_PATH}} to be substituted")
-	}
 	if strings.Contains(prompt, "{{PROGRESS_PATH}}") {
 		t.Error("Expected {{PROGRESS_PATH}} to be substituted")
 	}
@@ -33,11 +29,6 @@ func TestGetPrompt(t *testing.T) {
 		t.Error("Expected prompt to contain exact commit message 'feat: US-001 - Test Story'")
 	}
 
-	// Verify the PRD path appears in the prompt
-	if !strings.Contains(prompt, prdPath) {
-		t.Errorf("Expected prompt to contain PRD path %q", prdPath)
-	}
-
 	// Verify the progress path appears in the prompt
 	if !strings.Contains(prompt, progressPath) {
 		t.Errorf("Expected prompt to contain progress path %q", progressPath)
@@ -48,22 +39,14 @@ func TestGetPrompt(t *testing.T) {
 		t.Error("Expected prompt to contain inlined story context")
 	}
 
-	// Verify the prompt contains key instructions
-	if !strings.Contains(prompt, "chief-complete") {
-		t.Error("Expected prompt to contain chief-complete instruction")
-	}
-
-	if !strings.Contains(prompt, "ralph-status") {
-		t.Error("Expected prompt to contain ralph-status instruction")
-	}
-
-	if !strings.Contains(prompt, "passes: true") {
-		t.Error("Expected prompt to contain passes: true instruction")
+	// Verify the prompt contains chief-done stop condition
+	if !strings.Contains(prompt, "chief-done") {
+		t.Error("Expected prompt to contain chief-done instruction")
 	}
 }
 
 func TestGetPrompt_NoFileReadInstruction(t *testing.T) {
-	prompt := GetPrompt("/path/prd.json", "/path/progress.md", `{"id":"US-001"}`, "US-001", "Test Story")
+	prompt := GetPrompt("/path/progress.md", `{"id":"US-001"}`, "US-001", "Test Story")
 
 	// The prompt should NOT instruct Claude to read the PRD file
 	if strings.Contains(prompt, "Read the PRD") {
@@ -78,7 +61,7 @@ func TestPromptTemplateNotEmpty(t *testing.T) {
 }
 
 func TestGetPrompt_ChiefExclusion(t *testing.T) {
-	prompt := GetPrompt("/path/prd.json", "/path/progress.md", `{"id":"US-001"}`, "US-001", "Test Story")
+	prompt := GetPrompt("/path/progress.md", `{"id":"US-001"}`, "US-001", "Test Story")
 
 	// The prompt must instruct Claude to never stage or commit .chief/ files
 	if !strings.Contains(prompt, ".chief/") {
@@ -87,74 +70,6 @@ func TestGetPrompt_ChiefExclusion(t *testing.T) {
 	if !strings.Contains(prompt, "NEVER stage or commit") {
 		t.Error("Expected prompt to explicitly say NEVER stage or commit .chief/ files")
 	}
-	// The commit step should not say "commit ALL changes" anymore
-	if strings.Contains(prompt, "commit ALL changes") {
-		t.Error("Expected prompt to NOT say 'commit ALL changes' — it should exclude .chief/ files")
-	}
-}
-
-func TestGetConvertPrompt(t *testing.T) {
-	prdFilePath := "/path/to/prds/main/prd.md"
-	prompt := GetConvertPrompt(prdFilePath, "US")
-
-	// Verify the prompt is not empty
-	if prompt == "" {
-		t.Error("Expected GetConvertPrompt() to return non-empty prompt")
-	}
-
-	// Verify file path is substituted (not inlined content)
-	if !strings.Contains(prompt, prdFilePath) {
-		t.Error("Expected prompt to contain the PRD file path")
-	}
-	if strings.Contains(prompt, "{{PRD_FILE_PATH}}") {
-		t.Error("Expected {{PRD_FILE_PATH}} to be substituted")
-	}
-
-	// Verify the old {{PRD_CONTENT}} placeholder is completely removed
-	if strings.Contains(prompt, "{{PRD_CONTENT}}") {
-		t.Error("Expected {{PRD_CONTENT}} placeholder to be completely removed")
-	}
-
-	// Verify ID prefix is substituted
-	if strings.Contains(prompt, "{{ID_PREFIX}}") {
-		t.Error("Expected {{ID_PREFIX}} to be substituted")
-	}
-	if !strings.Contains(prompt, "US-001") {
-		t.Error("Expected prompt to contain US-001 when prefix is US")
-	}
-
-	// Verify key instructions are present
-	if !strings.Contains(prompt, "JSON") {
-		t.Error("Expected prompt to mention JSON")
-	}
-
-	if !strings.Contains(prompt, "userStories") {
-		t.Error("Expected prompt to describe userStories structure")
-	}
-
-	if !strings.Contains(prompt, `"passes": false`) {
-		t.Error("Expected prompt to specify passes: false default")
-	}
-
-	// Verify prompt instructs Claude to read the file
-	if !strings.Contains(prompt, "Read the PRD file") {
-		t.Error("Expected prompt to instruct Claude to read the PRD file")
-	}
-}
-
-func TestGetConvertPrompt_CustomPrefix(t *testing.T) {
-	prompt := GetConvertPrompt("/path/prd.md", "MFR")
-
-	// Verify custom prefix is used, not hardcoded US
-	if strings.Contains(prompt, "{{ID_PREFIX}}") {
-		t.Error("Expected {{ID_PREFIX}} to be substituted")
-	}
-	if !strings.Contains(prompt, "MFR-001") {
-		t.Error("Expected prompt to contain MFR-001 when prefix is MFR")
-	}
-	if !strings.Contains(prompt, "MFR-002") {
-		t.Error("Expected prompt to contain MFR-002 when prefix is MFR")
-	}
 }
 
 func TestGetInitPrompt(t *testing.T) {