fix: validate configured region

Author: NianJiuZst

src/config/loader.ts

@@ -2,6 +2,8 @@ import { readFileSync, writeFileSync, renameSync, existsSync } from 'fs';
 import { parseConfigFile, REGIONS, type Config, type ConfigFile, type Region } from './schema';
 import { ensureConfigDir, getConfigPath } from './paths';
 import { detectOutputFormat, type OutputFormat } from '../output/formatter';
+import { CLIError } from '../errors/base';
+import { ExitCode } from '../errors/codes';
 import type { GlobalFlags } from '../types/flags';
 
 export function readConfigFile(): ConfigFile {
@@ -33,6 +35,13 @@ export function loadConfig(flags: GlobalFlags): Config {
   const fileApiKey = file.api_key;
 
   const explicitRegion = (flags.region as string) || process.env.MINIMAX_REGION || undefined;
+  if (explicitRegion && !(explicitRegion in REGIONS)) {
+    throw new CLIError(
+      `Invalid region "${explicitRegion}". Valid values: ${Object.keys(REGIONS).join(', ')}`,
+      ExitCode.USAGE,
+    );
+  }
+
   const cachedRegion = file.region;
   const region = (explicitRegion || cachedRegion || 'global') as Region;
 

test/config/loader.test.ts

@@ -0,0 +1,59 @@
+import { describe, it, expect, beforeEach, afterEach } from 'bun:test';
+import { mkdirSync, rmSync } from 'fs';
+import { join } from 'path';
+import { tmpdir } from 'os';
+import { loadConfig } from '../../src/config/loader';
+import { CLIError } from '../../src/errors/base';
+import type { GlobalFlags } from '../../src/types/flags';
+
+const baseFlags: GlobalFlags = {
+  quiet: false,
+  verbose: false,
+  noColor: true,
+  yes: false,
+  dryRun: false,
+  help: false,
+  nonInteractive: true,
+  async: false,
+};
+
+describe('loadConfig', () => {
+  const testDir = join(tmpdir(), `mmx-config-test-${Date.now()}`);
+  const originalHome = process.env.HOME;
+  const originalRegion = process.env.MINIMAX_REGION;
+
+  beforeEach(() => {
+    mkdirSync(join(testDir, '.mmx'), { recursive: true });
+    process.env.HOME = testDir;
+    delete process.env.MINIMAX_REGION;
+  });
+
+  afterEach(() => {
+    process.env.HOME = originalHome;
+    if (originalRegion === undefined) delete process.env.MINIMAX_REGION;
+    else process.env.MINIMAX_REGION = originalRegion;
+    rmSync(testDir, { recursive: true, force: true });
+  });
+
+  it('rejects invalid --region values', () => {
+    expect(() => loadConfig({ ...baseFlags, region: 'mars' })).toThrow(CLIError);
+    expect(() => loadConfig({ ...baseFlags, region: 'mars' })).toThrow(
+      'Invalid region "mars". Valid values: global, cn',
+    );
+  });
+
+  it('rejects invalid MINIMAX_REGION values', () => {
+    process.env.MINIMAX_REGION = 'moon';
+
+    expect(() => loadConfig(baseFlags)).toThrow(
+      'Invalid region "moon". Valid values: global, cn',
+    );
+  });
+
+  it('accepts valid explicit region values', () => {
+    const config = loadConfig({ ...baseFlags, region: 'cn' });
+
+    expect(config.region).toBe('cn');
+    expect(config.baseUrl).toBe('https://api.minimaxi.com');
+  });
+});