Skip to content

Commit ff4e739

Browse files
authored
fix(ci): finalize PR notification design (remove octo-pr-feed + fix result-notify) (#32)
## Summary Finalizes the PR notification design. Clean, no-overlap ownership: | Workflow | Trigger | Sends to | |----------|---------|----------| | `octo-pr-result-notify.yml` | `[closed]` + `pull_request_review: [submitted]` | **global pr-feed** (`vars.OCTO_PR_FEED_GROUP_ID` with fallback) | | `octo-pr-review-feed.yml` | `[ready_for_review, review_requested]` | project group (repo-specific) | ### Design decisions (per product owner) - **`opened`/`reopened` events are not monitored** — only terminal states (merged/closed) and review outcomes - `octo-pr-feed.yml` is deleted — it was added in a prior pass but is not needed under the final design ### Changes - **`octo-pr-feed.yml`**: deleted - **`octo-pr-result-notify.yml`**: - Trigger: `[closed, reopened]` → `[closed]` (terminal state only) - `event_kind`: simplified to `pr_merged | pr_closed` - `feed_group_id`: `${{ vars.OCTO_PR_FEED_GROUP_ID || '1c303c142e9840f2a9b46c10b0972e8d' }}` (org variable with safe fallback) No application code modified. Co-authored-by: lml2468 <lml2468@users.noreply.github.com>
1 parent 354e104 commit ff4e739

2 files changed

Lines changed: 4 additions & 31 deletions

File tree

.github/workflows/octo-pr-feed.yml

Lines changed: 0 additions & 27 deletions
This file was deleted.

.github/workflows/octo-pr-result-notify.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Octo PR Result Notify
22

33
on:
44
pull_request_target:
5-
types: [closed, reopened]
5+
types: [closed]
66
pull_request_review:
77
types: [submitted]
88

@@ -18,11 +18,11 @@ jobs:
1818
pr_title: ${{ github.event.pull_request.title }}
1919
pr_url: ${{ github.event.pull_request.html_url }}
2020
pr_author: ${{ github.event.pull_request.user.login }}
21-
event_kind: ${{ github.event.action == 'closed' && github.event.pull_request.merged == true && 'pr_merged' || github.event.action == 'closed' && 'pr_closed' || 'pr_reopened' }}
21+
event_kind: ${{ github.event.pull_request.merged == true && 'pr_merged' || 'pr_closed' }}
2222
pr_additions: ${{ github.event.pull_request.additions }}
2323
pr_deletions: ${{ github.event.pull_request.deletions }}
2424
pr_changed_files: ${{ github.event.pull_request.changed_files }}
25-
feed_group_id: "bdc0df15fdb346508e4281f3df55f749"
25+
feed_group_id: ${{ vars.OCTO_PR_FEED_GROUP_ID || '1c303c142e9840f2a9b46c10b0972e8d' }}
2626
secrets:
2727
OCTO_BOT_TOKEN: ${{ secrets.OCTO_BOT_TOKEN }}
2828

@@ -40,6 +40,6 @@ jobs:
4040
pr_author: ${{ github.event.pull_request.user.login }}
4141
event_kind: ${{ github.event.review.state == 'approved' && 'review_approved' || 'review_changes_requested' }}
4242
reviewer: ${{ github.event.review.user.login }}
43-
feed_group_id: "bdc0df15fdb346508e4281f3df55f749"
43+
feed_group_id: ${{ vars.OCTO_PR_FEED_GROUP_ID || '1c303c142e9840f2a9b46c10b0972e8d' }}
4444
secrets:
4545
OCTO_BOT_TOKEN: ${{ secrets.OCTO_BOT_TOKEN }}

0 commit comments

Comments
 (0)