Commit ff4e739
authored
fix(ci): finalize PR notification design (remove octo-pr-feed + fix result-notify) (#32)
## Summary
Finalizes the PR notification design. Clean, no-overlap ownership:
| Workflow | Trigger | Sends to |
|----------|---------|----------|
| `octo-pr-result-notify.yml` | `[closed]` + `pull_request_review:
[submitted]` | **global pr-feed** (`vars.OCTO_PR_FEED_GROUP_ID` with
fallback) |
| `octo-pr-review-feed.yml` | `[ready_for_review, review_requested]` |
project group (repo-specific) |
### Design decisions (per product owner)
- **`opened`/`reopened` events are not monitored** — only terminal
states (merged/closed) and review outcomes
- `octo-pr-feed.yml` is deleted — it was added in a prior pass but is
not needed under the final design
### Changes
- **`octo-pr-feed.yml`**: deleted
- **`octo-pr-result-notify.yml`**:
- Trigger: `[closed, reopened]` → `[closed]` (terminal state only)
- `event_kind`: simplified to `pr_merged | pr_closed`
- `feed_group_id`: `${{ vars.OCTO_PR_FEED_GROUP_ID ||
'1c303c142e9840f2a9b46c10b0972e8d' }}` (org variable with safe fallback)
No application code modified.
Co-authored-by: lml2468 <lml2468@users.noreply.github.com>1 parent 354e104 commit ff4e739
2 files changed
Lines changed: 4 additions & 31 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
0 commit comments