include/functions.php: PHP Deprecated: The predefined locally scoped $http_response_header ....

[Gerdix]

Hi Visman,
I'm currently testing PunBB on PHP 8.5.2. Today I received this message in my error log: PHP Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in C:\xampp\htdocs\punbb\include\functions.php on line 384 (line numbering adjusted to your script).

"This variable is deprecated since PHP 8.5, and will disappear in PHP 9.0."

What's puzzling me a bit is this on lines 380 to 382:
if (function_exists('http_get_last_response_headers')) {
$http_response_header = http_get_last_response_headers();
}

I don't have this statement in my script at all. I may have removed it several months ago, when the script was still running on PHP 8.4.8, due to a different related error. But that's just one thought of mine.

[MioVisman]

For the current version of the code

		// Did we get anything?
		if ($content !== false)
		{
			if (function_exists('http_get_last_response_headers')) {
				$http_response_header = http_get_last_response_headers();
			}
			// Gotta love the fact that $http_response_header just appears in the global scope (*cough* hack! *cough*)
			$result['headers'] = $http_response_header;
			if (!$head_only)
				$result['content'] = $content;
		}

I ran punbb on PHP versions 8.4.15 and 8.5.2. I don't see any errors.
I went through both public pages and pages in the admin panel.

[Gerdix]

That's strange, the error occurred for me after I first ran the script on PHP 8.5.2. I'll add the missing statement back in. If I get the same error again, I'll definitely let you know. And thank you for your efforts and work over all these years 👍

[Gerdix]

Yes, it was only the missing statement in my script. No errors anymore. My fault :-(