[WIN32SS:USER] Fix ScrollBar class creation when using comctl32 v6, mute useless errors

For some reason, both Windows and Wine define ScrollBar class to be forwarded. Wine does not re-register the ScrollBar class, and Windows does not appear to do so either. Previously, ReactOS relied on a hack to register the ScrollBar class: https://github.com/reactos/reactos/blob/eecfbaeaa0bdef86f0cecff9828871be276ccd6e/dll/win32/comctl32/theming.c#L164. Wine uses a is_builtin_class function to determine if the class is implemented server side rather than user32/comctl32, so use the same function.

Wine switched to registering all of its comctl32 classes in RegisterClassNameW rather than its dllmain. See wine-mirror/wine@05421ef.
Remove errors when the class could not be located in the first pass, which is now the default behavior, which results in user32!VersionRegisterClass being called, which allows CreateWindow to succeed. I also confirmed that Windows's comctl32 registers its classes when RegisterClassNameW is called by user32, not at startup using a debugger.

Author: MishaProductions

win32ss/user/ntuser/class.c

@@ -1477,11 +1477,11 @@ IntGetAndReferenceClass(PUNICODE_STRING ClassName, HINSTANCE hInstance, BOOL bDe
    {
       if (IS_ATOM(ClassName->Buffer))
       {
-         ERR("Class 0x%p not found\n", ClassName->Buffer);
+         TRACE("Class 0x%p not found\n", ClassName->Buffer);
       }
       else
       {
-         ERR("Class \"%wZ\" not found\n", ClassName);
+         TRACE("Class \"%wZ\" not found\n", ClassName);
       }
 
       return NULL;

win32ss/user/ntuser/window.c

@@ -2214,7 +2214,7 @@ co_UserCreateWindowEx(CREATESTRUCTW* Cs,
    if(!Class)
    {
        EngSetLastError(ERROR_CANNOT_FIND_WND_CLASS);
-       ERR("Failed to find class %wZ\n", ClassName);
+       TRACE("Failed to find class %wZ\n", ClassName);
        goto cleanup;
    }
 

win32ss/user/user32/windows/class.c

@@ -47,25 +47,26 @@ LPCWSTR is_comctl32_class( const WCHAR *name )
 {
     static const WCHAR classesW[][20] =
     {
-        {'C','o','m','b','o','B','o','x','E','x','3','2',0},
-        {'m','s','c','t','l','s','_','h','o','t','k','e','y','3','2',0},
-        {'m','s','c','t','l','s','_','p','r','o','g','r','e','s','s','3','2',0},
-        {'m','s','c','t','l','s','_','s','t','a','t','u','s','b','a','r','3','2',0},
-        {'m','s','c','t','l','s','_','t','r','a','c','k','b','a','r','3','2',0},
-        {'m','s','c','t','l','s','_','u','p','d','o','w','n','3','2',0},
-        {'N','a','t','i','v','e','F','o','n','t','C','t','l',0},
-        {'R','e','B','a','r','W','i','n','d','o','w','3','2',0},
-        {'S','y','s','A','n','i','m','a','t','e','3','2',0},
-        {'S','y','s','D','a','t','e','T','i','m','e','P','i','c','k','3','2',0},
-        {'S','y','s','H','e','a','d','e','r','3','2',0},
-        {'S','y','s','I','P','A','d','d','r','e','s','s','3','2',0},
-        {'S','y','s','L','i','s','t','V','i','e','w','3','2',0},
-        {'S','y','s','M','o','n','t','h','C','a','l','3','2',0},
-        {'S','y','s','P','a','g','e','r',0},
-        {'S','y','s','T','a','b','C','o','n','t','r','o','l','3','2',0},
-        {'S','y','s','T','r','e','e','V','i','e','w','3','2',0},
-        {'T','o','o','l','b','a','r','W','i','n','d','o','w','3','2',0},
-        {'t','o','o','l','t','i','p','s','_','c','l','a','s','s','3','2',0},
+        L"ComboBoxEx32",
+        L"msctls_hotkey32",
+        L"msctls_progress32",
+        L"msctls_statusbar32",
+        L"msctls_trackbar32",
+        L"msctls_updown32",
+        L"NativeFontCtl",
+        L"ReBarWindow32",
+        L"SysAnimate32",
+        L"SysDateTimePick32",
+        L"SysHeader32",
+        L"SysIPAddress32",
+        L"SysLink",
+        L"SysListView32",
+        L"SysMonthCal32",
+        L"SysPager",
+        L"SysTabControl32",
+        L"SysTreeView32",
+        L"ToolbarWindow32",
+        L"tooltips_class32",
     };
 
     int min = 0, max = (sizeof(classesW) / sizeof(classesW[0])) - 1;
@@ -80,6 +81,27 @@ LPCWSTR is_comctl32_class( const WCHAR *name )
     return NULL;
 }
 
+static BOOL is_builtin_class( const WCHAR *name )
+{
+    static const WCHAR *classesW[] =
+    {
+        L"IME",
+        L"MDIClient",
+        L"Scrollbar",
+    };
+
+    int min = 0, max = _countof(classesW) - 1;
+
+    while (min <= max)
+    {
+        int res, pos = (min + max) / 2;
+        if (!(res = strcmpiW( name, classesW[pos] ))) return TRUE;
+        if (res < 0) max = pos - 1;
+        else min = pos + 1;
+    }
+    return FALSE;
+}
+
 LPCWSTR
 FASTCALL
 ClassNameToVersion(
@@ -128,6 +150,13 @@ ClassNameToVersion(
             RtlInitUnicodeString(&SectionName, lpszClass);
         }
     }
+
+    // check if the classes are built into win32k, if so use the non-versioned variant as comctl32 does not register the versioned class names
+    if (is_builtin_class(SectionName.Buffer))
+    {
+        return NULL;
+    }
+
 #ifdef USE_VERSIONED_CLASSES
     Status = RtlFindActivationContextSectionString( FIND_ACTCTX_SECTION_KEY_RETURN_HACTCTX,
                                                     NULL,
@@ -205,8 +234,6 @@ VersionRegisterClass(
     WCHAR ClassNameBuf[MAX_PATH] = {0};
     RTL_CALLER_ALLOCATED_ACTIVATION_CONTEXT_STACK_FRAME_EXTENDED Frame = { sizeof(Frame), 1 };
 
-    ERR("VersionRegisterClass: Attempting to call RegisterClassNameW in %S.\n", lpLibFileName);
-
     RtlActivateActivationContextUnsafeFast(&Frame, Contex);
 
     _SEH2_TRY