Skip to content

Commit 68b5fa2

Browse files
Revert "[ADVAPI32] Add SEH handling to some crypt functions"
This reverts commit 9844eff. Newer versions of wine added a pointer_from_handle function which does the same checks and includes try/catch.
1 parent 054c83f commit 68b5fa2

1 file changed

Lines changed: 0 additions & 65 deletions

File tree

dll/win32/advapi32/wine/crypt.c

Lines changed: 0 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -622,26 +622,13 @@ BOOL WINAPI CryptContextAddRef (HCRYPTPROV hProv, DWORD *pdwReserved, DWORD dwFl
622622
return FALSE;
623623
}
624624

625-
#ifdef __REACTOS__
626-
_SEH2_TRY
627-
{
628-
#endif
629625
if (pProv->dwMagic != MAGIC_CRYPTPROV)
630626
{
631627
SetLastError(ERROR_INVALID_PARAMETER);
632628
return FALSE;
633629
}
634630

635631
InterlockedIncrement(&pProv->refcount);
636-
#ifdef __REACTOS__
637-
}
638-
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
639-
{
640-
SetLastError(ERROR_INVALID_PARAMETER);
641-
_SEH2_YIELD(return FALSE);
642-
}
643-
_SEH2_END;
644-
#endif
645632
return TRUE;
646633
}
647634

@@ -759,25 +746,12 @@ BOOL WINAPI CryptCreateHash (HCRYPTPROV hProv, ALG_ID Algid, HCRYPTKEY hKey,
759746

760747
TRACE("(0x%lx, 0x%x, 0x%lx, %08x, %p)\n", hProv, Algid, hKey, dwFlags, phHash);
761748

762-
#ifdef __REACTOS__
763-
_SEH2_TRY
764-
{
765-
#endif
766749
if (!prov || !phHash || prov->dwMagic != MAGIC_CRYPTPROV ||
767750
(key && key->dwMagic != MAGIC_CRYPTKEY))
768751
{
769752
SetLastError(ERROR_INVALID_PARAMETER);
770753
return FALSE;
771754
}
772-
#ifdef __REACTOS__
773-
}
774-
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
775-
{
776-
SetLastError(ERROR_INVALID_PARAMETER);
777-
_SEH2_YIELD(return FALSE);
778-
}
779-
_SEH2_END;
780-
#endif
781755
if (dwFlags)
782756
{
783757
SetLastError(NTE_BAD_FLAGS);
@@ -832,10 +806,6 @@ BOOL WINAPI CryptDecrypt (HCRYPTKEY hKey, HCRYPTHASH hHash, BOOL Final,
832806

833807
TRACE("(0x%lx, 0x%lx, %d, %08x, %p, %p)\n", hKey, hHash, Final, dwFlags, pbData, pdwDataLen);
834808

835-
#ifdef __REACTOS__
836-
_SEH2_TRY
837-
{
838-
#endif
839809
if (!key || !pbData || !pdwDataLen ||
840810
!key->pProvider || key->dwMagic != MAGIC_CRYPTKEY ||
841811
key->pProvider->dwMagic != MAGIC_CRYPTPROV)
@@ -847,15 +817,6 @@ BOOL WINAPI CryptDecrypt (HCRYPTKEY hKey, HCRYPTHASH hHash, BOOL Final,
847817
prov = key->pProvider;
848818
return prov->pFuncs->pCPDecrypt(prov->hPrivate, key->hPrivate, hash ? hash->hPrivate : 0,
849819
Final, dwFlags, pbData, pdwDataLen);
850-
#ifdef __REACTOS__
851-
}
852-
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
853-
{
854-
SetLastError(ERROR_INVALID_PARAMETER);
855-
_SEH2_YIELD(return FALSE);
856-
}
857-
_SEH2_END;
858-
#endif
859820
}
860821

861822
/******************************************************************************
@@ -1138,10 +1099,6 @@ BOOL WINAPI CryptEncrypt (HCRYPTKEY hKey, HCRYPTHASH hHash, BOOL Final,
11381099

11391100
TRACE("(0x%lx, 0x%lx, %d, %08x, %p, %p, %d)\n", hKey, hHash, Final, dwFlags, pbData, pdwDataLen, dwBufLen);
11401101

1141-
#ifdef __REACTOS__
1142-
_SEH2_TRY
1143-
{
1144-
#endif
11451102
if (!key || !pdwDataLen || !key->pProvider ||
11461103
key->dwMagic != MAGIC_CRYPTKEY || key->pProvider->dwMagic != MAGIC_CRYPTPROV)
11471104
{
@@ -1152,15 +1109,6 @@ BOOL WINAPI CryptEncrypt (HCRYPTKEY hKey, HCRYPTHASH hHash, BOOL Final,
11521109
prov = key->pProvider;
11531110
return prov->pFuncs->pCPEncrypt(prov->hPrivate, key->hPrivate, hash ? hash->hPrivate : 0,
11541111
Final, dwFlags, pbData, pdwDataLen, dwBufLen);
1155-
#ifdef __REACTOS__
1156-
}
1157-
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
1158-
{
1159-
SetLastError(ERROR_INVALID_PARAMETER);
1160-
_SEH2_YIELD(return FALSE);
1161-
}
1162-
_SEH2_END;
1163-
#endif
11641112
}
11651113

11661114
/******************************************************************************
@@ -1473,10 +1421,6 @@ BOOL WINAPI CryptExportKey (HCRYPTKEY hKey, HCRYPTKEY hExpKey, DWORD dwBlobType,
14731421

14741422
TRACE("(0x%lx, 0x%lx, %d, %08x, %p, %p)\n", hKey, hExpKey, dwBlobType, dwFlags, pbData, pdwDataLen);
14751423

1476-
#ifdef __REACTOS__
1477-
_SEH2_TRY
1478-
{
1479-
#endif
14801424
if (!key || !pdwDataLen || !key->pProvider ||
14811425
key->dwMagic != MAGIC_CRYPTKEY || key->pProvider->dwMagic != MAGIC_CRYPTPROV)
14821426
{
@@ -1487,15 +1431,6 @@ BOOL WINAPI CryptExportKey (HCRYPTKEY hKey, HCRYPTKEY hExpKey, DWORD dwBlobType,
14871431
prov = key->pProvider;
14881432
return prov->pFuncs->pCPExportKey(prov->hPrivate, key->hPrivate, expkey ? expkey->hPrivate : 0,
14891433
dwBlobType, dwFlags, pbData, pdwDataLen);
1490-
#ifdef __REACTOS__
1491-
}
1492-
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
1493-
{
1494-
SetLastError(ERROR_INVALID_PARAMETER);
1495-
_SEH2_YIELD(return FALSE);
1496-
}
1497-
_SEH2_END;
1498-
#endif
14991434
}
15001435

15011436
/******************************************************************************

0 commit comments

Comments
 (0)