[CMAKE] Remove obsolete remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)

tkreuzer · tkreuzer · commit d2dc9355ab96 · 2026-05-07T06:27:58.000Z
diff --git a/base/system/msiexec/CMakeLists.txt b/base/system/msiexec/CMakeLists.txt
@@ -1,6 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 list(APPEND SOURCE
     msiexec.c
     service.c
diff --git a/dll/win32/combase/CMakeLists.txt b/dll/win32/combase/CMakeLists.txt
@@ -1,5 +1,5 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS -D_WIN32_WINNT=0x502)
+remove_definitions(-D_WIN32_WINNT=0x502)
 add_definitions(-D_WIN32_WINNT=0x600)
 include_directories(${REACTOS_SOURCE_DIR}/sdk/include/wine)
 
diff --git a/dll/win32/coml2/CMakeLists.txt b/dll/win32/coml2/CMakeLists.txt
@@ -1,5 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 include_directories(${REACTOS_SOURCE_DIR}/sdk/include/wine)
 spec2def(coml2.dll coml2.spec ADD_IMPORTLIB)
 
diff --git a/dll/win32/msi/CMakeLists.txt b/dll/win32/msi/CMakeLists.txt
@@ -1,5 +1,5 @@
 
-remove_definitions(-D_WIN32_WINNT=0x502 -D_CRT_NON_CONFORMING_SWPRINTFS)
+remove_definitions(-D_WIN32_WINNT=0x502)
 add_definitions(-D_WIN32_WINNT=0x600)
 
 add_definitions(-D__WINESRC__ -DMSIRUNMODE=MSIRUNMODE_T)
diff --git a/dll/win32/msvcrt/CMakeLists.txt b/dll/win32/msvcrt/CMakeLists.txt
@@ -3,9 +3,6 @@
 # Global compile options
 ###############################################################################
 
-# Use conforming swprintfs
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 # This requires NT6
 remove_definitions(-D_WIN32_WINNT=0x502 -DWINVER=0x502)
 add_definitions(-D_WIN32_WINNT=0x601 -DWINVER=0x601)
diff --git a/dll/win32/ole32/CMakeLists.txt b/dll/win32/ole32/CMakeLists.txt
@@ -1,5 +1,5 @@
 
-remove_definitions(-D_WIN32_WINNT=0x502 -D_CRT_NON_CONFORMING_SWPRINTFS)
+remove_definitions(-D_WIN32_WINNT=0x502)
 add_definitions(-D_WIN32_WINNT=0x600)
 
 add_definitions(
diff --git a/dll/win32/propsys/CMakeLists.txt b/dll/win32/propsys/CMakeLists.txt
@@ -1,5 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 add_definitions(-D_PROPSYS_)
 spec2def(propsys.dll propsys.spec ADD_IMPORTLIB)
 
diff --git a/dll/win32/riched20/CMakeLists.txt b/dll/win32/riched20/CMakeLists.txt
@@ -1,5 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 spec2def(riched20.dll riched20.spec ADD_IMPORTLIB)
 
 list(APPEND SOURCE
diff --git a/dll/win32/ucrtbase/CMakeLists.txt b/dll/win32/ucrtbase/CMakeLists.txt
@@ -7,8 +7,6 @@ list(REMOVE_ITEM INCLUDE_DIRS "${REACTOS_SOURCE_DIR}/sdk/include/crt")
 set_property(DIRECTORY . PROPERTY INCLUDE_DIRECTORIES ${INCLUDE_DIRS})
 include_directories(${REACTOS_SOURCE_DIR}/sdk/include/ucrt)
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 add_compile_definitions(
     _UCRT
     _CORECRT_BUILD
diff --git a/dll/win32/windowscodecs/CMakeLists.txt b/dll/win32/windowscodecs/CMakeLists.txt
@@ -5,7 +5,6 @@ add_definitions(
     -DWINE_REGISTER_DLL)
 
 remove_definitions(-D_WIN32_WINNT=0x502)
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 add_definitions(-D_WIN32_WINNT=0x600)
 
 include_directories(
diff --git a/dll/win32/winhttp/CMakeLists.txt b/dll/win32/winhttp/CMakeLists.txt
@@ -1,5 +1,5 @@
 
-remove_definitions(-D_WIN32_WINNT=0x502 -D_CRT_NON_CONFORMING_SWPRINTFS)
+remove_definitions(-D_WIN32_WINNT=0x502)
 add_definitions(-D_WIN32_WINNT=0x600)
 
 add_definitions(
diff --git a/dll/win32/wintrust/CMakeLists.txt b/dll/win32/wintrust/CMakeLists.txt
@@ -1,6 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 spec2def(wintrust.dll wintrust.spec ADD_IMPORTLIB)
 
 list(APPEND SOURCE
diff --git a/modules/rosapps/applications/fraginator/CMakeLists.txt b/modules/rosapps/applications/fraginator/CMakeLists.txt
@@ -1,6 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 list(APPEND SOURCE
 	Fraginator.cpp
 	MainDialog.cpp
diff --git a/modules/rostests/winetests/combase/CMakeLists.txt b/modules/rostests/winetests/combase/CMakeLists.txt
@@ -1,7 +1,6 @@
 
 add_definitions(-D__ROS_LONG64__)
 add_definitions(-DUSE_WINE_TODOS)
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 
 include_directories(BEFORE ${REACTOS_SOURCE_DIR}/sdk/include/wine)
 spec2def(wine.combase.test.dll wine.combase.test.spec)
diff --git a/modules/rostests/winetests/kernel32/CMakeLists.txt b/modules/rostests/winetests/kernel32/CMakeLists.txt
@@ -1,6 +1,6 @@
 
 include_directories(BEFORE ${REACTOS_SOURCE_DIR}/sdk/include/wine)
-remove_definitions(-DWINVER=0x502 -D_WIN32_IE=0x600 -D_WIN32_WINNT=0x502 -D_CRT_NON_CONFORMING_SWPRINTFS)
+remove_definitions(-DWINVER=0x502 -D_WIN32_IE=0x600 -D_WIN32_WINNT=0x502)
 add_definitions(-DWINVER=0x0A00 -D_WIN32_WINNT=0x0A00 -DNTDDI_VERSION=0x0A000007)
 
 # Comment this block out if you want to debug the heap issue with these tests on ROS x64. ROSTESTS-415
diff --git a/modules/rostests/winetests/mscoree/CMakeLists.txt b/modules/rostests/winetests/mscoree/CMakeLists.txt
@@ -1,5 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 add_definitions(-DUSE_WINE_TODOS)
 
 add_executable(mscoree_winetest
diff --git a/modules/rostests/winetests/msvcrt/CMakeLists.txt b/modules/rostests/winetests/msvcrt/CMakeLists.txt
@@ -1,6 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 list(APPEND SOURCE
     cpp.c
     data.c
diff --git a/modules/rostests/winetests/msxml4/CMakeLists.txt b/modules/rostests/winetests/msxml4/CMakeLists.txt
@@ -1,6 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 add_definitions(-DUSE_WINE_TODOS)
 
 list(APPEND SOURCE
diff --git a/modules/rostests/winetests/msxml6/CMakeLists.txt b/modules/rostests/winetests/msxml6/CMakeLists.txt
@@ -1,6 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 add_definitions(-DUSE_WINE_TODOS)
 
 list(APPEND SOURCE
diff --git a/modules/rostests/winetests/ntdll/CMakeLists.txt b/modules/rostests/winetests/ntdll/CMakeLists.txt
@@ -1,6 +1,5 @@
 
 include_directories(BEFORE ${REACTOS_SOURCE_DIR}/sdk/include/wine)
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 add_definitions(-D__WINESRC__ -DWINETEST_USE_DBGSTR_LONGLONG)
 
 remove_definitions(-D_WIN32_WINNT=0x502 -DWINVER=0x502)
diff --git a/modules/rostests/winetests/uiautomationcore/CMakeLists.txt b/modules/rostests/winetests/uiautomationcore/CMakeLists.txt
@@ -1,5 +1,4 @@
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 remove_definitions(-D_WIN32_WINNT=0x502)
 add_definitions(-D_WIN32_WINNT=0x600)
 
diff --git a/modules/rostests/winetests/user32/CMakeLists.txt b/modules/rostests/winetests/user32/CMakeLists.txt
@@ -2,8 +2,6 @@
 remove_definitions(-DWINVER=0x502 -D_WIN32_WINNT=0x502)
 add_definitions(-DWINVER=0x0A00 -D_WIN32_WINNT=0x0A00 -DNTDDI_VERSION=0x0A000005)
 
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
-
 list(APPEND SOURCE
     broadcast.c
     class.c
diff --git a/modules/rostests/winetests/winhttp/CMakeLists.txt b/modules/rostests/winetests/winhttp/CMakeLists.txt
@@ -1,6 +1,5 @@
 
 add_definitions(-DUSE_WINE_TODOS)
-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)
 
 list(APPEND SOURCE
     notification.c

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`
`2`		`-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)`
`3`	`2`	`include_directories(${REACTOS_SOURCE_DIR}/sdk/include/wine)`
`4`	`3`	`spec2def(coml2.dll coml2.spec ADD_IMPORTLIB)`
`5`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`
`2`		`-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)`
`3`	`2`	`add_definitions(-D_PROPSYS_)`
`4`	`3`	`spec2def(propsys.dll propsys.spec ADD_IMPORTLIB)`
`5`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`
`2`		`-remove_definitions(-D_CRT_NON_CONFORMING_SWPRINTFS)`
`3`	`2`	`spec2def(riched20.dll riched20.spec ADD_IMPORTLIB)`
`4`	`3`
`5`	`4`	`list(APPEND SOURCE`