Skip to content

Commit 49cca80

Browse files
committed
chore: Verify New Architecture
- Need a CMAKE workaround for Windows as path names are too long (specifying a CMAKE version in an `.env` file didn't work).
1 parent e2ad039 commit 49cca80

6 files changed

Lines changed: 22 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ and this project attempts to adhere to [Semantic Versioning](https://semver.org/
77

88
## [Unreleased]
99

10+
### Other
11+
12+
- Validate that the New Architecture works in example app.
13+
- Required a workaround for CMAKE due to long paths in Windows.
14+
1015
## [0.8.0] - 2025-02-13
1116

1217
### ⚡ Changes

android/gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
MetadataRetriever_kotlinVersion=1.9.24
1+
MetadataRetriever_kotlinVersion=1.9.25
22
MetadataRetriever_minSdkVersion=24
33
MetadataRetriever_targetSdkVersion=34
44
MetadataRetriever_compileSdkVersion=35
5-
MetadataRetriever_ndkversion=21.4.7075529
5+
MetadataRetriever_ndkversion=26.1.10909125

android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

examples/benchmarking-demo/android/app/build.gradle

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,17 @@ android {
9393
targetSdkVersion rootProject.ext.targetSdkVersion
9494
versionCode 1
9595
versionName "1.0.0"
96+
97+
/**
98+
* Work around on Windows due potentially having a Filename longer than 260 characters.
99+
* Basically, we need to change what version of `ninja` CMAKE uses.
100+
* - Ref: https://github.com/ninja-build/ninja/issues/1900#issuecomment-1817532728
101+
*/
102+
externalNativeBuild {
103+
cmake {
104+
arguments "-DCMAKE_MAKE_PROGRAM=C:\\ninja\\ninja.exe", "-DCMAKE_OBJECT_PATH_MAX=1024"
105+
}
106+
}
96107
}
97108
/**
98109
* https://developer.android.com/build/configure-apk-splits

examples/benchmarking-demo/android/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
3535
# your application. You should enable this flag either if you want
3636
# to write custom TurboModules/Fabric components OR use libraries that
3737
# are providing them.
38-
newArchEnabled=false
38+
newArchEnabled=true
3939

4040
# Use this property to enable or disable the Hermes JS engine.
4141
# If set to false, you will be using JSC instead.

examples/benchmarking-demo/app.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
"expo-build-properties",
2424
{
2525
"android": {
26-
"newArchEnabled": false,
2726
"enableProguardInReleaseBuilds": true,
2827
"enableShrinkResourcesInReleaseBuilds": true
2928
}
3029
}
3130
]
32-
]
31+
],
32+
"newArchEnabled": true
3333
}
3434
}

0 commit comments

Comments
 (0)