Conversation
A future test project will be designed such that failing to quit the VM after timing out would severely inhibit the performance of the other tests.
…his script" Closes TurboWarp#249 Regression from 20f25f2
- Node.js 22 - Replace npm run test with npm run tap to avoid unnecessarily running ESLint twice
- update actions/setup-node to fix extra 10 minute delay in CI - update Node.js - use version ranges instead of commit hashes to get future updates automatically (we already trust the GitHub Actions team) - don't use npm cache in deploy workflow
) This is because beepbox's script: https://cdn.jsdelivr.net/npm/beepbox@4.2.0/global/beepbox_synth.min.js has a sourceMappingURL comment at the bottom for whatever reason, causing it to become //# sourceMappingURL=beepbox_synth.min.js.map;return beepbox; This is obviously going to break and might also be the case with other libraries too, hot just beepbox. Ported from AmpMod: https://codeberg.org/ampmod/ampmod/commit/0daf1021bdc8e67a1f0d08b91ce500605fcaa711
It is still not perfect. Better though Fixes TurboWarp#257 Closes TurboWarp#324 (this one uses a different approach and restricts to 30 FPS and checks if the platform is known to benefit before we turn on battery draining workarounds)
They can return 0 if the sprite does not exist Fixes TurboWarp#262 Closes TurboWarp#325 (this one uses a different fix and has tests) There are broader issues about compiled sensing_of not handling dynamic sprite create/delete. We should tackle that later. The other PR wouldn't really fix this either.
It can return 0 when fencing is disabled
Fixes stringifying -0, objects, arrays
Why: * We use immutable.js 3.8.2 which is ancient and not getting updates * immutable.js adds 55KB to the bundle, of which we use almost nothing * immutable.js's treatment of 0 and -0 is nonsensical and would require weird workarounds like TurboWarp#320 * We don't benefit from the whole immutability thing What we're doing instead: * We have our own MonitorState and MonitorRecord classes * We track dirty-ness at modification time instead of equality checking every tick * scratch-gui and packager can continue to think we use immutable.js without causing issues in either direction * our objects have enough stubs that immutable.js-expecting consumers are ok * when receiving an object, we check if it looks like an immutable.js one and ask for the plain JS version so that works okay too
Nothing in Scratch uses this
I thought this may have been part of fixing a sb2 -> sb3 corruption issue. But from commit log, it seems this was added to prevent extensions from making mistakes. With the scratch-parser change, those mistakes are now considered features. Seems safe to just do remove these checks all the time. Closes TurboWarp#332
…rboWarp#335) Co-authored-by: Cubester <78769806+CubesterYT@users.noreply.github.com> Co-authored-by: Thomas Weber <muffin@muffin.ink>
Our editor relies on the mutation for control_stop to know if there is a connection below. Spork does not export that mutation anymore. Instead, we will just generate the mutation to fix errors on loading.
Fixes TurboWarp/sb3fix#125 in the safest way that hopefully has no unforseen breakages on weird behaviors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings mw-next into develop (127 commits). Highlights:
🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.