fix

Author: MisterRaindrop

ci/scripts/start_minio.sh

@@ -116,13 +116,27 @@ create_bucket() {
   "${MC_BIN}" mb --ignore-existing "local/${MINIO_BUCKET}"
 }
 
+start_minio_windows() {
+  local minio_dir="${RUNNER_TEMP:-/tmp}"
+  local minio_bin="${minio_dir}/minio.exe"
+  curl -sSL "https://dl.min.io/server/minio/release/windows-amd64/minio.exe" -o "${minio_bin}"
+  MINIO_ROOT_USER="${MINIO_ROOT_USER}" MINIO_ROOT_PASSWORD="${MINIO_ROOT_PASSWORD}" \
+    "${minio_bin}" server "${minio_dir}/minio-data" --console-address ":${MINIO_CONSOLE_PORT}" &
+  wait_for_minio
+}
+
 case "$(uname -s)" in
   Darwin*)
     if ! start_minio_docker; then
       start_minio_macos
     fi
     ;;
-  Linux*|MINGW*|MSYS*|CYGWIN*)
+  MINGW*|MSYS*|CYGWIN*)
+    if ! start_minio_docker; then
+      start_minio_windows
+    fi
+    ;;
+  Linux*)
     start_minio_docker
     ;;
   *)

src/iceberg/file_io_registry.h

@@ -39,10 +39,8 @@ namespace iceberg {
 class ICEBERG_EXPORT FileIORegistry {
  public:
   /// Well-known implementation names
-  static constexpr const char* kArrowLocalFileIO =
-      "org.apache.iceberg.arrow.ArrowFileIO";
-  static constexpr const char* kArrowS3FileIO =
-      "org.apache.iceberg.arrow.ArrowS3FileIO";
+  static constexpr const char* kArrowLocalFileIO = "org.apache.iceberg.arrow.ArrowFileIO";
+  static constexpr const char* kArrowS3FileIO = "org.apache.iceberg.arrow.ArrowS3FileIO";
 
   /// Factory function type for creating FileIO instances.
   using Factory = std::function<Result<std::shared_ptr<FileIO>>(

src/iceberg/test/file_io_registry_test.cc

@@ -50,9 +50,7 @@ TEST(FileIoRegistryTest, RegisterAndLoad) {
       impl_name,
       [](const std::string& /*warehouse*/,
          const std::unordered_map<std::string, std::string>& /*properties*/)
-          -> Result<std::shared_ptr<FileIO>> {
-        return std::make_shared<MockFileIO>();
-      });
+          -> Result<std::shared_ptr<FileIO>> { return std::make_shared<MockFileIO>(); });
 
   auto result = FileIORegistry::Load(impl_name, "/test/warehouse", {});
   ASSERT_THAT(result, IsOk());
@@ -78,18 +76,14 @@ TEST(FileIoRegistryTest, OverrideExistingRegistration) {
       impl_name,
       [](const std::string& /*warehouse*/,
          const std::unordered_map<std::string, std::string>& /*properties*/)
-          -> Result<std::shared_ptr<FileIO>> {
-        return std::make_shared<MockFileIO>();
-      });
+          -> Result<std::shared_ptr<FileIO>> { return std::make_shared<MockFileIO>(); });
 
   // Override with a different factory
   FileIORegistry::Register(
       impl_name,
       [](const std::string& /*warehouse*/,
          const std::unordered_map<std::string, std::string>& /*properties*/)
-          -> Result<std::shared_ptr<FileIO>> {
-        return std::make_shared<MockFileIO>();
-      });
+          -> Result<std::shared_ptr<FileIO>> { return std::make_shared<MockFileIO>(); });
 
   // Should still work (the override replaces the original)
   auto result = FileIORegistry::Load(impl_name, "/test/warehouse", {});
@@ -114,7 +108,7 @@ TEST(FileIoRegistryTest, FactoryReceivesWarehouseAndProperties) {
       });
 
   std::unordered_map<std::string, std::string> props = {{"key1", "val1"},
-                                                         {"key2", "val2"}};
+                                                        {"key2", "val2"}};
   auto result = FileIORegistry::Load(impl_name, "s3://my-bucket/warehouse", props);
   ASSERT_THAT(result, IsOk());
   EXPECT_EQ(captured_warehouse, "s3://my-bucket/warehouse");