fix

Author: MisterRaindrop

src/iceberg/file_io_registry.cc

@@ -0,0 +1,21 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "iceberg/file_io_registry.h"
+
+// FileIORegistry is header-only (all methods are inline/static).
+// This translation unit ensures the header compiles cleanly.

src/iceberg/file_io_registry.h

@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#pragma once
+
+#include <functional>
+#include <memory>
+#include <mutex>
+#include <string>
+#include <unordered_map>
+
+#include "iceberg/file_io.h"
+#include "iceberg/iceberg_export.h"
+#include "iceberg/result.h"
+
+namespace iceberg {
+
+/// \brief Registry for FileIO implementations.
+///
+/// Provides a mechanism to register and load FileIO implementations by name.
+/// This allows the REST catalog (and others) to resolve FileIO implementations
+/// at runtime based on configuration properties like "io-impl".
+class ICEBERG_EXPORT FileIORegistry {
+ public:
+  /// Well-known implementation names
+  static constexpr const char* kArrowLocalFileIO =
+      "org.apache.iceberg.arrow.ArrowFileIO";
+  static constexpr const char* kArrowS3FileIO =
+      "org.apache.iceberg.arrow.ArrowS3FileIO";
+
+  /// Factory function type for creating FileIO instances.
+  using Factory = std::function<Result<std::shared_ptr<FileIO>>(
+      const std::string& warehouse,
+      const std::unordered_map<std::string, std::string>& properties)>;
+
+  /// \brief Register a FileIO factory under the given name.
+  ///
+  /// \param name The implementation name (e.g., "org.apache.iceberg.arrow.ArrowFileIO")
+  /// \param factory The factory function that creates the FileIO instance.
+  static void Register(const std::string& name, Factory factory) {
+    std::lock_guard lock(Mutex());
+    Registry()[name] = std::move(factory);
+  }
+
+  /// \brief Load a FileIO implementation by name.
+  ///
+  /// \param name The implementation name to look up.
+  /// \param warehouse The warehouse location URI.
+  /// \param properties Configuration properties to pass to the factory.
+  /// \return A shared_ptr to the FileIO instance, or an error if not found.
+  static Result<std::shared_ptr<FileIO>> Load(
+      const std::string& name, const std::string& warehouse,
+      const std::unordered_map<std::string, std::string>& properties) {
+    Factory factory;
+    {
+      std::lock_guard lock(Mutex());
+      auto it = Registry().find(name);
+      if (it == Registry().end()) {
+        return std::unexpected<Error>(
+            {.kind = ErrorKind::kNotFound,
+             .message = "FileIO implementation not found: " + name});
+      }
+      factory = it->second;
+    }
+    // Invoke factory outside the lock to avoid blocking other Register/Load
+    // calls and to prevent deadlocks if the factory calls back into the registry.
+    return factory(warehouse, properties);
+  }
+
+ private:
+  static std::unordered_map<std::string, Factory>& Registry() {
+    static std::unordered_map<std::string, Factory> registry;
+    return registry;
+  }
+
+  static std::mutex& Mutex() {
+    static std::mutex mutex;
+    return mutex;
+  }
+};
+
+/// \brief Property keys for FileIO configuration.
+struct FileIOProperties {
+  /// The FileIO implementation class name (e.g., "org.apache.iceberg.arrow.ArrowFileIO")
+  static constexpr const char* kImpl = "io-impl";
+};
+
+}  // namespace iceberg