fix(request): stringify non-string XHR error responses - #3077
Open
Hashim1999164 wants to merge 1 commit into
Open
fix(request): stringify non-string XHR error responses#3077Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
When responseType is json (or other non-text types), responseText is unavailable and Error() turned object bodies into "[object Object]". JSON.stringify those values so error.message stays readable. Fixes MithrilJS#2802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
responseTypeisjson(the default) or another non-text type, readingresponseTextthrows and the catch path passed the parsed response object intonew Error(...). That produced an unhelpful"[object Object]"message even thougherror.responsealready held the body.This stringifies non-string error messages with
JSON.stringify(falling back toString(...)) soerror.messagestays readable for JSON error bodies and other non-text response types.Fixes #2802
Test plan
"[object Object]"npx ospec request/tests/test-request.js(117 assertions passed)