Enhance: Stereo and local Model Selection#13
Open
sp1np0rtal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds several quality-of-life and usability improvements to the MusicGen node:
models/musicgendirectory instead of requiring downloads from Hugging Face.Notes
During testing I observed that model selection changes can occur while a valid model object is already loaded. For that reason the model reload check remains necessary to detect model swaps and reload the correct checkpoint when the selected model changes.
Tested with local
musicgen-mediumandmusicgen-smallcheckpoints and verified that changing the model selection triggers loading of the newly selected model.New features:
Tested with:
Existing workflows continue to function as before. If no local model is selected, behavior remains unchanged.