Skip to content

Commit e33c6e0

Browse files
authored
Remove extraneous attributes on LegacyDialog's DialogButton (#1108)
* Remove extraneous attributes * Update CHANGELOG.md
1 parent 7b69e09 commit e33c6e0

3 files changed

Lines changed: 11 additions & 6 deletions

File tree

org.mixedrealitytoolkit.uxcore/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
44

5+
## Unreleased
6+
7+
### Fixed
8+
9+
* Fixed "Attribute 'SerializeField' is not valid on this declaration type. It is only valid on 'field' declarations" error on `DialogButton` in Unity 6.3. [PR #1108](https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/1108)
10+
511
## [3.3.0] - 2025-11-12
612

713
### Added

org.mixedrealitytoolkit.uxcore/LegacyDialog/DialogButton.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,12 @@ namespace MixedReality.Toolkit.UX.Deprecated
1111
/// Handling click event and dismiss dialog
1212
/// </summary>
1313
/// <remarks>
14-
/// This and the <see cref="MixedReality.Toolkit.UX.Deprecated.Dialog">Legacy Dialog</see> are deprecated. Please migrate to the
15-
/// new <see cref="MixedReality.Toolkit.UX.Dialog">Dialog</see>. If you'd like to continue using the
16-
/// <see cref="MixedReality.Toolkit.UX.Deprecated.Dialog">Legacy Dialog</see> implementation, it is recommended that the legacy code
17-
/// be copied to the application's code base, and maintained independently by the application developer. Otherwise, it is strongly recommended
14+
/// This and the <see cref="MixedReality.Toolkit.UX.Deprecated.Dialog">Legacy Dialog</see> are deprecated. Please migrate to the
15+
/// new <see cref="MixedReality.Toolkit.UX.Dialog">Dialog</see>. If you'd like to continue using the
16+
/// <see cref="MixedReality.Toolkit.UX.Deprecated.Dialog">Legacy Dialog</see> implementation, it is recommended that the legacy code
17+
/// be copied to the application's code base, and maintained independently by the application developer. Otherwise, it is strongly recommended
1818
/// that the application be updated to use the new <see cref="MixedReality.Toolkit.UX.DialogPool">DialogPool</see> system.
1919
/// </remarks>
20-
[SerializeField, Tooltip("The TextMeshPro component for displaying text on the button itself.")]
2120
[Obsolete("This legacy dialog system has been deprecated. Please migrate to the new dialog system, see MixedReality.Toolkit.UX.DialogPool for more details.")]
2221
public class DialogButton : MonoBehaviour
2322
{

org.mixedrealitytoolkit.uxcore/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "org.mixedrealitytoolkit.uxcore",
3-
"version": "3.3.0-development",
3+
"version": "3.3.1-development",
44
"description": "Core interaction and visualization scripts for building MR UI components. Intended to be consumed when building UX libraries. For pre-existing library of components, see the UX Components package.",
55
"displayName": "MRTK UX Core Scripts",
66
"msftFeatureCategory": "MRTK3",

0 commit comments

Comments
 (0)