Skip to content

Improve Font Icon Set name assignment#1077

Merged
simon-ign merged 38 commits into
MixedRealityToolkit:feature/XRI3from
keveleigh:new-icon-naming
May 19, 2026
Merged

Improve Font Icon Set name assignment#1077
simon-ign merged 38 commits into
MixedRealityToolkit:feature/XRI3from
keveleigh:new-icon-naming

Conversation

@keveleigh

@keveleigh keveleigh commented Nov 11, 2025

Copy link
Copy Markdown
Contributor
  • Creates a new Font Icon Set Definition asset that contains all valid icon names for a set
  • This new asset can be assigned to a Font Icon Set, allowing for a dropdown of names when assigning names to icons
  • Updated the flow and arrangement of the icons while setting their names, to allow more to be visible at once and reduce scrolling
  • Also fixes some bugs:
    • Selected glyph highlighting wasn't setting a valid color entry, so it wasn't working (_Color to _FaceColor)
    • Fixed a race condition where DrawFontGlyphsGrid was trying to read an entry from the deserialized Font Icon Set when the entry had only just been written to the serialized representation and wasn't yet updated
    • Fixed the Font Icon Set asset not being marked dirty when icon names were updated

Provides a migration path from the current "Icon #" names

From this:
{F80EAE1E-7476-4526-A9A8-2ECB9121148B}

to this:
{DB5A99C9-C92C-4409-8E9D-4DBA47DFDD56}

@keveleigh keveleigh self-assigned this Nov 11, 2025
@keveleigh keveleigh force-pushed the new-icon-naming branch 3 times, most recently from ac67238 to 3d3ab91 Compare November 12, 2025 23:49
@keveleigh keveleigh force-pushed the new-icon-naming branch 5 times, most recently from ce3ec1d to f0954b0 Compare May 19, 2026 20:25
@keveleigh keveleigh marked this pull request as ready for review May 19, 2026 22:21
@keveleigh keveleigh requested a review from a team as a code owner May 19, 2026 22:21
@keveleigh keveleigh force-pushed the new-icon-naming branch 2 times, most recently from 79302a4 to 1272425 Compare May 19, 2026 22:54
@simon-ign simon-ign merged commit db1cbd6 into MixedRealityToolkit:feature/XRI3 May 19, 2026
2 checks passed
@keveleigh keveleigh deleted the new-icon-naming branch May 19, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants