Skip to content

Add #if UNITY_EDITOR to PackageValidator #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keveleigh merged 2 commits into from
Jun 5, 2026
Merged

Add #if UNITY_EDITOR to PackageValidator #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f215910
Add #if UNITY_EDITOR
keveleigh Jun 5, 2026
7231da5
Update CHANGELOG.md
keveleigh Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions org.mixedrealitytoolkit.core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
### Changed

* Updated code style in `HandsSubsystemDescriptor`, `MRTKSubsystemDescriptor`, `DictationSubsystemDescriptor`, and `XRSubsystemHelpers`. [PR #1109](https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/1109)
* Updated `PackageValidator` to only be valid if `UNITY_EDITOR` is true. [PR #1125](https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/1125)

### Fixed

Expand Down
15 changes: 4 additions & 11 deletions org.mixedrealitytoolkit.core/Tests/TestUtilities/PackageValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
// Copyright (c) Mixed Reality Toolkit Contributors
// Licensed under the BSD 3-Clause

// Disable "missing XML comment" warning for tests. While nice to have, this documentation is not required.
#pragma warning disable CS1591
#if HAS_ASSET_STORE_VALIDATION
#if HAS_ASSET_STORE_VALIDATION && UNITY_EDITOR

using System;
using System.Collections.Generic;
Expand All @@ -26,12 +24,7 @@ public static class PackageValidator
/// </exception>
public static PackageValidatorResults Validate(string packageName)
{
PackageInfo info = UpmPackageInfo(packageName);
if (info == null)
{
throw new ArgumentException($"No package found with name \"{packageName}\"");
}

PackageInfo info = UpmPackageInfo(packageName) ?? throw new ArgumentException($"No package found with name \"{packageName}\"");
string packageId = $"{info.name}@{info.version}";
ValidationSuite.ValidatePackage(packageId, ValidationType.AssetStore);

Expand Down Expand Up @@ -70,5 +63,5 @@ private static PackageInfo[] UpmListOffline(string packageIdOrName = null)
}
}
}
#endif // HAS_ASSET_STORE_VALIDATION
#pragma warning restore CS1591

#endif // HAS_ASSET_STORE_VALIDATION && UNITY_EDITOR