Hide missing localized market descriptions#6442
Closed
SeniorZhai wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the market details “About” section so it only displays when a non-blank description exists for the user’s current locale, removing the previous English/first-non-empty fallback behavior.
Changes:
- Replaced the inline fallback chain for market descriptions with a dedicated locale-selection helper.
- Updated UI binding to hide the “About” container when the localized description is missing/blank.
- Added a new helper file to centralize localized description selection logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/one/mixin/android/ui/wallet/MarketDetailsFragment.kt | Switches description selection to localized-only behavior and hides the About section when absent. |
| app/src/main/java/one/mixin/android/ui/wallet/MarketDescription.kt | Introduces a helper for selecting the localized market description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+6
| fun selectLocalizedMarketDescription( | ||
| descriptions: Map<String, String>, | ||
| language: String, | ||
| ): String? = descriptions[language]?.takeIf { it.isNotBlank() } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification