Skip to content

Commit 5716d5b

Browse files
Linux Build Service AccountGerrit - the friendly Code Review server
authored andcommitted
Merge "Make storage permission only show one configration."
2 parents e4d1833 + df27c81 commit 5716d5b

1 file changed

Lines changed: 21 additions & 18 deletions

File tree

src/com/android/packageinstaller/permission/ui/handheld/AppPermissionsFragment.java

100755100644
Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import android.content.pm.PackageManager.NameNotFoundException;
3131
import android.content.pm.PermissionInfo;
3232
import android.graphics.drawable.Drawable;
33+
import android.Manifest;
3334
import android.net.Uri;
3435
import android.os.Bundle;
3536
import android.preference.Preference;
@@ -243,24 +244,25 @@ private void loadPreferences() {
243244
}
244245
if (AppPermissionGroup.isStrictOpEnable() && isPlatform) {
245246
try {
246-
PackageManager pm = context.getPackageManager();
247-
for (Permission permission : group.getPermissions()) {
248-
PermissionInfo perm = pm.getPermissionInfo(permission.getName(), 0);
249-
final String[] filterPermissions = new String[]{permission.getName()};
250-
251-
if (perm.protectionLevel == PermissionInfo.PROTECTION_DANGEROUS) {
252-
SwitchPreference preference_permission = new SwitchPreference(context);
253-
preference_permission.setOnPreferenceChangeListener(this);
254-
preference_permission.setKey(permission.getName());
255-
preference_permission.setTitle(perm.loadLabel(pm));
256-
preference_permission.setPersistent(false);
257-
preference_permission.setEnabled(true);
258-
AppPermissionGroup permissionGroup = getPermisssionGroup(perm.group);
259-
preference_permission.setChecked(
260-
permissionGroup.areRuntimePermissionsGranted(filterPermissions));
261-
screen.addPreference(preference_permission);
262-
} else if (perm.protectionLevel == PermissionInfo.PROTECTION_NORMAL) {
263-
continue;
247+
if (!group.getName().equals(Manifest.permission_group.STORAGE)) {
248+
PackageManager pm = context.getPackageManager();
249+
for (Permission permission : group.getPermissions()) {
250+
PermissionInfo perm = pm.getPermissionInfo(permission.getName(), 0);
251+
final String[] filterPermissions = new String[]{permission.getName()};
252+
if (perm.protectionLevel == PermissionInfo.PROTECTION_DANGEROUS) {
253+
SwitchPreference preference_permission = new SwitchPreference(context);
254+
preference_permission.setOnPreferenceChangeListener(this);
255+
preference_permission.setKey(permission.getName());
256+
preference_permission.setTitle(perm.loadLabel(pm));
257+
preference_permission.setPersistent(false);
258+
preference_permission.setEnabled(true);
259+
AppPermissionGroup permissionGroup = getPermisssionGroup(perm.group);
260+
preference_permission.setChecked(
261+
permissionGroup.areRuntimePermissionsGranted(filterPermissions));
262+
screen.addPreference(preference_permission);
263+
} else if (perm.protectionLevel == PermissionInfo.PROTECTION_NORMAL) {
264+
continue;
265+
}
264266
}
265267
}
266268
} catch (NameNotFoundException e) {
@@ -302,6 +304,7 @@ private AppPermissionGroup getPermisssionGroup(String group) {
302304
}
303305

304306
private void updateEveryPermissionPreference(AppPermissionGroup group) {
307+
if (group.getName().equals(Manifest.permission_group.STORAGE)) return;
305308
PackageManager pm = getContext().getPackageManager();
306309
PreferenceScreen screen = getPreferenceScreen();
307310
for (Permission permission : group.getPermissions()) {

0 commit comments

Comments
 (0)