Skip to content

Commit 915b46c

Browse files
committed
Introduced geofencing param for mobileid cli, the geofencing data in the sign request becomes optional
1 parent be4eb71 commit 915b46c

4 files changed

Lines changed: 16 additions & 3 deletions

File tree

mid-java-client-usage/src/main/java/ch/swisscom/mid/client/cli/Cli.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ public class Cli {
5454
private static final String PARAM_REQUEST_TIMEOUT = "req-timeout";
5555
private static final String PARAM_REST = "rest";
5656
private static final String PARAM_SOAP = "soap";
57+
private static final String PARAM_GEO = "geofencing";
5758
private static final String PARAM_VALIDATE_SIGNATURE = "validate";
5859
private static final String PARAM_HELP = "help";
5960

@@ -86,6 +87,7 @@ public class Cli {
8687
private static boolean validateSignature = false;
8788
private static String interfaceType;
8889
private static int verboseLevel;
90+
private static boolean addGeofencingSrv = false;
8991

9092
public static void main(String[] args) {
9193
versionProvider = new ClientVersionProvider();
@@ -167,7 +169,11 @@ public static void main(String[] args) {
167169
request.getDataToBeSigned().setData(dtbs);
168170
request.getMobileUser().setMsisdn(msisdn);
169171
request.setSignatureProfile(SignatureProfiles.ANY_LOA4);
170-
request.addAdditionalService(new GeofencingAdditionalService());
172+
173+
if (addGeofencingSrv) {
174+
request.addAdditionalService(new GeofencingAdditionalService());
175+
}
176+
171177
request.setTrafficObserver(prettyPrinterTrafficObserver);
172178
request.setUserResponseTimeOutInSeconds(requestTimeout);
173179

@@ -355,6 +361,10 @@ private static void parseArguments(String[] args) {
355361
validateSignature = true;
356362
break;
357363
}
364+
case PARAM_GEO: {
365+
addGeofencingSrv = true;
366+
break;
367+
}
358368
case PARAM_MSISDN: {
359369
if (argValue == null) {
360370
if (argIndex + 1 < args.length) {

mid-java-client-usage/src/main/java/ch/swisscom/mid/client/samples/Utils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public static ClientConfiguration buildClientConfig() {
4343
tls.setTrustStoreFile("/home/localuser/truststore.jks");
4444
tls.setTrustStorePassword("secret");
4545
tls.setHostnameVerification(true);
46+
tls.setSslContext("TLSv1.2");
4647

4748
HttpConfiguration http = config.getHttp();
4849
http.setConnectionTimeoutInMs(20 * 1000);

mid-java-client-usage/src/main/resources/cli-files/config-sample.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ client.keyStore.file=keystore.jks
55
client.keyStore.password=secret
66
client.keyStore.keyPassword=secret
77
client.keyStore.certAlias=my-cert-alias
8-
client.tls.sslContext=SSLv3
8+
client.tls.sslContext=TLSv1.2
99
# --
1010
client.http.connectionTimeoutInSeconds=20
1111
client.http.responseTimeoutInSeconds=100

mid-java-client-usage/src/main/resources/cli-files/usage.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ Arguments:
2222

2323
-receipt - For sign operation. Send a receipt after the signature is acquired successfully
2424

25+
-geofencing - For sign operation. Request additional geofencing data
26+
2527
-validate - For sign operation. Validate the signature once it is successfully acquired
2628

2729
-msisdn=41790000000 - The target MSISDN for the chosen operation
@@ -59,7 +61,7 @@ Use cases:
5961
- ./bin/mid-client.sh -sign -sync -receipt -msisdn=41790000000 -lang=en -dtbs="Do you want to login?" -soap -vv
6062
- ./bin/mid-client.sh \
6163
-config=my-config.properties \
62-
-sign -sync -receipt \
64+
-sign -sync -receipt -geofencing \
6365
-msisdn=41790000000 \
6466
-lang=en -dtbs="Do you want to login?" \
6567
-soap -vv

0 commit comments

Comments
 (0)