Skip to content

Commit df8b46a

Browse files
authored
Remove example specific fileIO (#3)
Remove example specific fileIO Signed-off-by: Yoshimasa Niwa <niw@niw.at>
1 parent 3ade874 commit df8b46a

4 files changed

Lines changed: 10 additions & 8 deletions

File tree

Examples/BazelXCBBuildService/Sources/RequestHandler.swift

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,13 @@ final class RequestHandler: HybridXCBBuildServiceRequestHandler {
2222

2323
// We use negative numbers to ensure no duplication with XCBBuildService (though it seems that doesn't matter)
2424
private var lastBazelBuildNumber: Int64 = 0
25-
25+
26+
private let fileIO: NonBlockingFileIO
27+
28+
init(fileIO: NonBlockingFileIO) {
29+
self.fileIO = fileIO
30+
}
31+
2632
func handleRequest(_ request: RPCRequest<BazelXCBBuildServiceRequestPayload>, context: Context) {
2733
// Unless `forwardRequest` is set to `false`, at the end we forward the request to XCBBuildService
2834
var shouldForwardRequest = true

Examples/BazelXCBBuildService/Sources/main.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ do {
3030
let service = try HybridXCBBuildService(
3131
name: "BazelXCBBuildService",
3232
group: group,
33-
fileIO: fileIO,
34-
requestHandler: RequestHandler()
33+
requestHandler: RequestHandler(fileIO: fileIO)
3534
)
3635

3736
do {

Sources/XCBBuildServiceProxyKit/Hybrid/HybridRPCRequestHandler.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,12 @@ final class HybridRPCRequestHandler<RequestHandler: HybridXCBBuildServiceRequest
1515
typealias Request = InboundIn
1616
typealias Response = OutboundIn
1717

18-
private let fileIO: NonBlockingFileIO
1918
private let xcbBuildService: XCBBuildService
2019
private let requestHandler: RequestHandler
2120

2221
private var responsePromises: [UInt64: EventLoopPromise<Response>] = [:]
2322

24-
init(fileIO: NonBlockingFileIO, xcbBuildService: XCBBuildService, requestHandler: RequestHandler) {
25-
self.fileIO = fileIO
23+
init(xcbBuildService: XCBBuildService, requestHandler: RequestHandler) {
2624
self.xcbBuildService = xcbBuildService
2725
self.requestHandler = requestHandler
2826
}

Sources/XCBBuildServiceProxyKit/Hybrid/HybridXCBBuildService.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public final class HybridXCBBuildService<RequestHandler: HybridXCBBuildServiceRe
99
private let bootstrap: NIOPipeBootstrap
1010

1111
// TODO: Move NIO specific stuff into class
12-
public init(name: String, group: EventLoopGroup, fileIO: NonBlockingFileIO, requestHandler: RequestHandler) throws {
12+
public init(name: String, group: EventLoopGroup, requestHandler: RequestHandler) throws {
1313
self.name = name
1414
self.group = group
1515

@@ -33,7 +33,6 @@ public final class HybridXCBBuildService<RequestHandler: HybridXCBBuildServiceRe
3333
RPCResponseEncoder<RequestHandler.ResponsePayload>(),
3434
// RPCRequests from Xcode, RPCResponses from XCBBuildService
3535
HybridRPCRequestHandler<RequestHandler>(
36-
fileIO: fileIO,
3736
xcbBuildService: xcbBuildService,
3837
requestHandler: requestHandler
3938
),

0 commit comments

Comments
 (0)