Skip to content

Commit 0a2665d

Browse files
committed
Fix remote_download_regex matching all files unconditionally
The regex pattern `.*|.*\.(ext1|ext2|...)$` matches everything because `.*` before `|` is an unbounded wildcard with no anchor. This makes the extension filter useless, causing all remote cache outputs to be downloaded. Remove the `.*|` so only files with the listed extensions (plus indexstores when enabled) are downloaded.
1 parent ba7c9e7 commit 0a2665d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

xcodeproj/internal/bazel_integration_files/generate_index_build_bazel_dependencies.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ readonly build_pre_config_flags=(
5656
# This is brittle. If different file extensions are used for compilation
5757
# inputs, they will need to be added to this list. Ideally we can stop doing
5858
# this once Bazel adds support for a Remote Output Service.
59-
"--remote_download_regex=${indexstores_regex}.*|.*\.(cfg|c|C|cc|cl|cpp|cu|cxx|c++|def|h|H|hh|hpp|hxx|h++|hmap|ilc|inc|inl|ipp|tcc|tlh|tli|tpp|m|modulemap|mm|pch|swift|swiftdoc|swiftmodule|swiftsourceinfo|yaml)$"
59+
"--remote_download_regex=${indexstores_regex}.*\.(cfg|c|C|cc|cl|cpp|cu|cxx|c++|def|h|H|hh|hpp|hxx|h++|hmap|ilc|inc|inl|ipp|tcc|tlh|tli|tpp|m|modulemap|mm|pch|swift|swiftdoc|swiftmodule|swiftsourceinfo|yaml)$"
6060
)
6161

6262
source "$BAZEL_INTEGRATION_DIR/bazel_build.sh"

0 commit comments

Comments
 (0)