fix: add station_id validation for v2.1 also

Author: hbruch

gbfs-validator-java/src/main/java/org/entur/gbfs/validation/validator/versions/Version21.java

@@ -23,6 +23,7 @@
 import java.util.Map;
 import org.entur.gbfs.validation.validator.rules.CustomRuleSchemaPatcher;
 import org.entur.gbfs.validation.validator.rules.NoInvalidReferenceToRegionInStationInformation;
+import org.entur.gbfs.validation.validator.rules.NoInvalidReferenceToStation;
 import org.entur.gbfs.validation.validator.rules.NoInvalidReferenceToVehicleTypesInStationStatus;
 import org.entur.gbfs.validation.validator.rules.NoMissingCurrentRangeMetersInVehicleStatusForMotorizedVehicles;
 import org.entur.gbfs.validation.validator.rules.NoMissingOrInvalidVehicleTypeIdInVehicleStatusWhenVehicleTypesExist;
@@ -54,7 +55,8 @@ public class Version21 extends AbstractVersion {
       "station_status",
       List.of(
         new NoInvalidReferenceToVehicleTypesInStationStatus(),
-        new NoMissingVehicleTypesAvailableWhenVehicleTypesExists()
+        new NoMissingVehicleTypesAvailableWhenVehicleTypesExists(),
+        new NoInvalidReferenceToStation("station_information")
       ),
       "free_bike_status",
       List.of(
@@ -68,7 +70,10 @@ public class Version21 extends AbstractVersion {
       "system_information",
       List.of(new NoMissingStoreUriInSystemInformation("free_bike_status")),
       "station_information",
-      List.of(new NoInvalidReferenceToRegionInStationInformation())
+      List.of(
+        new NoInvalidReferenceToRegionInStationInformation(),
+        new NoInvalidReferenceToStation("station_status")
+      )
     );
 
   protected Version21() {

gbfs-validator-java/src/test/resources/fixtures/v2.1/station_information.json

@@ -5,14 +5,24 @@
   "data": {
     "stations": [
       {
-        "station_id": "pga",
+        "station_id": "station1",
         "name": "Parking garage A",
         "lat": 12.345678,
         "lon": 45.678901,
         "vehicle_type_capacity": {
           "abc123": 7,
           "def456": 9
         }
+      },
+      {
+        "station_id": "station2",
+        "name": "SE Belmont & SE 10th",
+        "lat": 45.516445,
+        "lon": -122.655775,
+        "vehicle_type_capacity": {
+          "abc123": 0,
+          "def456": 0
+        }
       }
     ]
   }

gbfs-validator-java/src/test/resources/fixtures/v2.1/station_information_virtual.json

@@ -5,7 +5,7 @@
   "data":{
     "stations":[
       {
-        "station_id":"station12",
+        "station_id":"station2",
         "station_name":"SE Belmont & SE 10 th ",
         "is_valet_station":false,
         "is_virtual_station":true,

gbfs-validator-java/src/test/resources/fixtures/v2.1/station_status.json

@@ -5,7 +5,7 @@
   "data": {
     "stations": [
       {
-        "station_id": "station 1",
+        "station_id": "station1",
         "is_installed": true,
         "is_renting": true,
         "is_returning": true,
@@ -27,7 +27,7 @@
           "count": 0
         }]
       }, {
-        "station_id": "station 2",
+        "station_id": "station2",
         "is_installed": true,
         "is_renting": true,
         "is_returning": true,