Skip to content

upgraded to Java 17#200

Merged
qcdyx merged 4 commits intomasterfrom
195-upgrade-java-to-17-version
Apr 14, 2026
Merged

upgraded to Java 17#200
qcdyx merged 4 commits intomasterfrom
195-upgrade-java-to-17-version

Conversation

@qcdyx
Copy link
Copy Markdown

@qcdyx qcdyx commented Mar 26, 2026

Summary:

  • Update project pom.xml and resolve dependency errors
  • Audit plugin/dependency compatibility in gtfs-realtime-validator-webapp/pom.xml and gtfs-realtime-validator-lib/pom.xml (maven-compiler-plugin, maven-surefire-plugin, maven-shade-plugin).

Expected behavior:

Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with mvn test to make sure you didn't break anything
  • Format the title like "feat: {new feature short description}" or "fix: {describe what was fixed}". Title must follow the Conventional Commit Specification (https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Mar 26, 2026 that may be closed by this pull request
@qcdyx qcdyx marked this pull request as ready for review March 26, 2026 14:06
@qcdyx
Copy link
Copy Markdown
Author

qcdyx commented Mar 26, 2026

Blocked by #199

davidgamez and others added 3 commits April 13, 2026 16:51
…oid connection leaking; rollbacked transactions before closeSession; used Java property names for HQL queries.
@qcdyx
Copy link
Copy Markdown
Author

qcdyx commented Apr 14, 2026

Pushed a fix that increased the database connection pool from 1 to 10, closed a leaked session in getSessionData(), made closeSession() roll back active transactions before closing, added try-finally blocks around all session usage to prevent leaks on exceptions, and changed two HQL queries in BackgroundTask to use Java property paths (gtfsRtFeedModel.gtfsRtId, gtfsFeedModel.feedId) instead of database column names (rtFeedId, gtfsFeedID) which Hibernate 6 no longer accepts.

Tested locally, works well.

image

Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qcdyx qcdyx merged commit 7041fa3 into master Apr 14, 2026
2 checks passed
@qcdyx qcdyx deleted the 195-upgrade-java-to-17-version branch April 14, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Java to 17 version

2 participants