Conversation
This reverts commit 8db5f1d.
emmambd
left a comment
emmambd
left a comment
There was a problem hiding this comment.
Left comments, largely related to reviewing the officialness of the data
| } | ||
| }, | ||
| "urls": { | ||
| "direct_download": "https://www.motionbuscard.org.cy/opendata/downloadfile?file=GTFS%5C11_google_transit.zip&rel=True", |
There was a problem hiding this comment.
Good catch that this is official data! https://www.motionbuscard.org.cy Let's update all the other motionbuscard URLs to be official as well as part of this PR.
| "mdb_source_id": 2904, | ||
| "data_type": "gtfs", | ||
| "provider": "Czech national bus feed JDF", | ||
| "location": { |
There was a problem hiding this comment.
Are we able to verify the officialness of the feed? Not sure from the URL
There was a problem hiding this comment.
The URL looks like an open source cloud sharing site. Couldn't find anything online about the feed itself (I'm going to mark it as unofficial).
There was a problem hiding this comment.
I'd leave it empty, not as "false"
There was a problem hiding this comment.
Wait so if unofficial, we should just leave the field as an empty string? I thought we should mark it:
"is_official": "False"
There was a problem hiding this comment.
If we're confident it's false we can set it as such. In this case, it's ambiguous, so I would leave it empty
There was a problem hiding this comment.
@emmambd Seems like the is_official field has to be populated, should I change the schema? Or maybe just keep it as false for now?
| "provider": "Hamburger Verkehrsverbund GmbH (HVV)", | ||
| "status": "active", | ||
| "location": { | ||
| "country_code": "DE", |
| "extracted_on": "2025-11-26 19:33:48.552556+00:00" | ||
| }, | ||
| "subdivision_name": "Hessen", | ||
| "municipality": "Wächtersbach" |
There was a problem hiding this comment.
Doesn't look like official data, am I wrong?
There was a problem hiding this comment.
I looked up Cross Solution and its definitely unofficial!
| "subdivision_name": "Southern Finland", | ||
| "municipality": "Uusimaa" | ||
| }, | ||
| "urls": { |
| "data_type": "gtfs", | ||
| "provider": "TRENITALIA S.p.A.", | ||
| "status": "inactive", | ||
| "status": "deprecated", |
| "municipality": "Brașov" | ||
| }, | ||
| "urls": { | ||
| "direct_download": "https://raw.githubusercontent.com/szjozsef/osm2gtfs/refs/heads/master/output/gtfs/ro-ratbv.zip", |
There was a problem hiding this comment.
Looks unofficial unless you can clarify otherwise
| } | ||
| }, | ||
| "urls": { | ||
| "direct_download": "https://github.com/szjozsef/osm2gtfs/raw/refs/heads/master/output/gtfs/ro-ratbv.zip", |
There was a problem hiding this comment.
Don't redirect, the new feed looks unofficial. I'd add the second one but mark it as unofficial data
|
@ianktc You can remove the field and then it'll work fine |
2 participants
Addresses issues:
#1095
#1133
#1140
#891
#1060
#1019
#1007
#948
#1062