Skip to content

Batch of import#1450

Merged
ianktc merged 10 commits into
mainfrom
import/may28
May 28, 2026
Merged

Batch of import#1450
ianktc merged 10 commits into
mainfrom
import/may28

Conversation

@ianktc
Copy link
Copy Markdown
Contributor

@ianktc ianktc commented May 28, 2026

From 12 feeds with 'automated' tag in backlog in progress column

@ianktc ianktc marked this pull request as ready for review May 28, 2026 18:45
Copy link
Copy Markdown
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Comments all relate to official status, e.g. when it can be set to false

"mdb_source_id": 3182,
"data_type": "gtfs",
"provider": "Urban Trans Vlora",
"location": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the incoming verified feed definition, setting the official field more consistently will be really important. This looks definitively unofficial to me, so it's worth marking as "false"

"country_code": "ES",
"bounding_box": {
"minimum_latitude": null,
"maximum_latitude": null,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more unofficial data?

"minimum_latitude": null,
"maximum_latitude": null,
"minimum_longitude": null,
"maximum_longitude": null,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks unofficial

"minimum_latitude": null,
"maximum_latitude": null,
"minimum_longitude": null,
"maximum_longitude": null,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

official?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this one might be unoffiical https://www.mpkrzeszow.pl/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

"municipality": "Barreiro",
"bounding_box": {
"minimum_latitude": null,
"maximum_latitude": null,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official based on domain?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure this one out definitively from the domain because it raises 404, but its probably safe to mark official

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the "backend" part of the domain to test

"country_code": "RO",
"bounding_box": {
"minimum_latitude": null,
"maximum_latitude": null,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unofficial?

@ianktc ianktc merged commit d9fdc6d into main May 28, 2026
9 checks passed
@ianktc ianktc deleted the import/may28 branch May 28, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants