lint and test

Author: Alessandro100

functions-python/backfill_dataset_service_date_range/src/main.py

@@ -178,7 +178,7 @@ def backfill_datasets(session: "Session"):
             if extracted_timezone is not None:
                 dataset.agency_timezone = extracted_timezone
 
-            formatted_dates = utc_service_start_date + " - " + utc_service_end_date
+            formatted_dates = f"{utc_service_start_date:%Y-%m-%d %H:%M} - {utc_service_end_date:%Y-%m-%d %H:%M}"
             logging.info(
                 f"Updated gtfsdataset ID {gtfsdataset_id} with value: {formatted_dates}"
             )

functions-python/backfill_dataset_service_date_range/tests/test_backfill_dataset_service_date_range_main.py

@@ -2,6 +2,7 @@
 from main import backfill_datasets, backfill_dataset_service_date_range, is_version_gte
 from shared.database_gen.sqlacodegen_models import Gtfsdataset
 from test_shared.test_utils.database_utils import default_db_url
+from datetime import datetime, timezone
 
 import requests
 
@@ -74,9 +75,16 @@ def test_backfill_datasets(mock_get, mock_storage_client):
 
     changes_count = backfill_datasets(mock_session)
 
+    expected_range_start = datetime.strptime("2023-01-01", "%Y-%m-%d").replace(
+        hour=0, minute=0, tzinfo=timezone.utc
+    )
+    expected_range_end = datetime.strptime("2023-12-31", "%Y-%m-%d").replace(
+        hour=23, minute=59, tzinfo=timezone.utc
+    )
+
     assert changes_count == 1
-    assert mock_dataset.service_date_range_start == "2023-01-01"
-    assert mock_dataset.service_date_range_end == "2023-12-31"
+    assert mock_dataset.service_date_range_start == expected_range_start
+    assert mock_dataset.service_date_range_end == expected_range_end
     mock_get.assert_called_once_with(
         "http://example-1.com/report.json"
     )  # latest validation report