Skip to content

Commit 3546ed2

Browse files
committed
revert permissions
1 parent fac1525 commit 3546ed2

7 files changed

Lines changed: 1 addition & 35 deletions

File tree

.github/workflows/db-update-dev.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ jobs:
3434
USER_DB_ENVIRONMENT: ${{ vars.DEV_MOBILITY_FEEDS_ENVIRONMENT }}
3535
# DRY_RUN: use provided input if defined (workflow_dispatch/workflow_call); fallback to false on push events
3636
DRY_RUN: ${{ inputs.DRY_RUN || false }}
37-
USERS_APP_ROLE_1PASSWORD: ${{ vars.DEV_POSTGRE_USER_APP_NAME_1PASSWORD }}
3837
secrets:
3938
DB_USER_PASSWORD: ${{ secrets.DEV_POSTGRE_USER_PASSWORD }}
4039
DB_USER_NAME: ${{ secrets.DEV_POSTGRE_USER_NAME }}

.github/workflows/db-update-prod.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
DB_ENVIRONMENT: ${{ vars.PROD_MOBILITY_FEEDS_ENVIRONMENT }}
2727
# DRY_RUN is passed through directly from inputs
2828
DRY_RUN: ${{ inputs.DRY_RUN }}
29-
USERS_APP_ROLE_1PASSWORD: ${{ vars.PROD_POSTGRE_USER_APP_NAME_1PASSWORD }}
3029
secrets:
3130
# DB auth and connectivity
3231
DB_USER_PASSWORD: ${{ secrets.PROD_POSTGRE_USER_PASSWORD }}

.github/workflows/db-update-qa.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
DB_ENVIRONMENT: ${{ vars.QA_MOBILITY_FEEDS_ENVIRONMENT }}
2727
# DRY_RUN is passed through directly from inputs
2828
DRY_RUN: ${{ inputs.DRY_RUN }}
29-
USERS_APP_ROLE_1PASSWORD: ${{ vars.QA_POSTGRE_USER_APP_NAME_1PASSWORD }}
3029
secrets:
3130
# DB auth and connectivity
3231
DB_USER_PASSWORD: ${{ secrets.QA_POSTGRE_USER_PASSWORD }}

.github/workflows/db-update.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ on:
2929
required: false
3030
default: ''
3131
type: string
32-
USERS_APP_ROLE_1PASSWORD:
33-
description: 1Password reference for the PostgreSQL role used by the users-DB application (e.g. op://vault/item/field).
34-
required: false
35-
default: ''
36-
type: string
3732
secrets:
3833
DB_USER_PASSWORD: #
3934
description: PostgreSQL User Password
@@ -81,7 +76,6 @@ jobs:
8176
GCP_FEED_SSH_USER: "op://rbiv7rvkkrsdlpcrz3bmv7nmcu/GCP_FEED_SSH_USER/username"
8277
GCP_FEED_BASTION_NAME: "op://rbiv7rvkkrsdlpcrz3bmv7nmcu/GCP_FEED_BASTION_NAME/username"
8378
GCP_FEED_BASTION_SSH_KEY: "op://rbiv7rvkkrsdlpcrz3bmv7nmcu/GCP_FEED_BASTION_SSH_KEY/private key"
84-
USERS_APP_ROLE: ${{ inputs.USERS_APP_ROLE_1PASSWORD }}
8579

8680
- name: Tunnel
8781
run: |
@@ -140,5 +134,5 @@ jobs:
140134
export LIQUIBASE_COMMAND_USERNAME=${{ secrets.DB_USER_NAME }}
141135
export LIQUIBASE_COMMAND_PASSWORD=${{ secrets.DB_USER_PASSWORD }}
142136
export LIQUIBASE_LOG_LEVEL=FINE
143-
liquibase update -Dusers_app_role=${{ env.USERS_APP_ROLE }}
137+
liquibase update
144138

docker-compose.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ services:
103103
- --log-level=1
104104
- --classpath=postgresql-42.7.8.jar
105105
- update
106-
- -Dusers_app_role=${POSTGRES_USER}
107106
depends_on:
108107
postgres:
109108
condition: service_healthy
@@ -123,7 +122,6 @@ services:
123122
- --log-level=1
124123
- --classpath=postgresql-42.7.8.jar
125124
- update
126-
- -Dusers_app_role=${POSTGRES_USER}
127125
depends_on:
128126
postgres-test:
129127
condition: service_healthy

liquibase/changelog_user.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,4 @@
1515
<include file="changes_user/feat_1684.sql" relativeToChangelogFile="true"/>
1616
<!-- Add feature_flag and user_feature_flag tables -->
1717
<include file="changes_user/feat_1694.sql" relativeToChangelogFile="true"/>
18-
<!-- Grant app role access to all users DB tables (covers future tables via ALTER DEFAULT PRIVILEGES) -->
19-
<include file="changes_user/feat_1694_grants.sql" relativeToChangelogFile="true"/>
2018
</databaseChangeLog>

liquibase/changes_user/feat_1694_grants.sql

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)