fx rename

Author: davidgamez

functions-python/tasks_executor/src/tasks/validation_reports/rebuild_missing_validation_reports.py

@@ -148,7 +148,7 @@ def rebuild_missing_validation_reports(
 
     # Apply limit inside the GCS blob check so we stop as soon as we have
     # enough valid datasets, without discarding candidates that would pass.
-    valid_datasets = _filter_datasets_with_existing_blob(datasets, limit=limit)
+    valid_datasets = _filter_out_datasets_without_blob(datasets, limit=limit)
     logging.info(
         "%s datasets have a GCS blob and will be triggered", len(valid_datasets)
     )
@@ -283,7 +283,7 @@ def _get_datasets_for_validation(
     return query.all()
 
 
-def _filter_datasets_with_existing_blob(
+def _filter_out_datasets_without_blob(
     datasets: List[tuple],
     limit: Optional[int] = None,
 ) -> List[tuple]:

functions-python/tasks_executor/tests/tasks/validation_reports/test_rebuild_missing_validation_reports.py

@@ -113,7 +113,7 @@ def _make_session_mock(self, datasets=None):
         return session
 
     @patch(f"{_MODULE}._get_validator_version", return_value="7.0.0")
-    @patch(f"{_MODULE}._filter_datasets_with_existing_blob", return_value=[])
+    @patch(f"{_MODULE}._filter_out_datasets_without_blob", return_value=[])
     @patch(f"{_MODULE}.TaskExecutionTracker")
     def test_dry_run_returns_count_without_triggering(
         self, tracker_cls, filter_blob_mock, version_mock
@@ -141,7 +141,7 @@ def test_dry_run_returns_count_without_triggering(
         )
 
     @patch(f"{_MODULE}._get_validator_version", return_value="7.0.0")
-    @patch(f"{_MODULE}._filter_datasets_with_existing_blob")
+    @patch(f"{_MODULE}._filter_out_datasets_without_blob")
     @patch(f"{_MODULE}.execute_workflows", return_value=["ds-1", "ds-2"])
     @patch(f"{_MODULE}.TaskExecutionTracker")
     def test_triggers_workflows_when_not_dry_run(
@@ -162,7 +162,7 @@ def test_triggers_workflows_when_not_dry_run(
         self.assertFalse(result["params"]["dry_run"])
 
     @patch(f"{_MODULE}._get_validator_version", return_value="7.0.0")
-    @patch(f"{_MODULE}._filter_datasets_with_existing_blob")
+    @patch(f"{_MODULE}._filter_out_datasets_without_blob")
     @patch(f"{_MODULE}.execute_workflows", return_value=["ds-1"])
     @patch(f"{_MODULE}.TaskExecutionTracker")
     def test_limit_slices_datasets(
@@ -187,9 +187,7 @@ def test_limit_slices_datasets(
         self.assertEqual(result["total_in_call"], 5)
 
     @patch(f"{_MODULE}._get_validator_version", return_value="7.0.0")
-    @patch(
-        f"{_MODULE}._filter_datasets_with_existing_blob", return_value=[("f", "ds-1")]
-    )
+    @patch(f"{_MODULE}._filter_out_datasets_without_blob", return_value=[("f", "ds-1")])
     @patch(f"{_MODULE}.execute_workflows", return_value=["ds-1"])
     @patch(f"{_MODULE}.TaskExecutionTracker")
     def test_bypass_db_update_passed_explicitly(
@@ -206,9 +204,7 @@ def test_bypass_db_update_passed_explicitly(
         self.assertTrue(call_kwargs["bypass_db_update"])
 
     @patch(f"{_MODULE}._get_validator_version", return_value="7.0.0")
-    @patch(
-        f"{_MODULE}._filter_datasets_with_existing_blob", return_value=[("f", "ds-1")]
-    )
+    @patch(f"{_MODULE}._filter_out_datasets_without_blob", return_value=[("f", "ds-1")])
     @patch(f"{_MODULE}.execute_workflows", return_value=["ds-1"])
     @patch(f"{_MODULE}.TaskExecutionTracker")
     def test_bypass_db_update_defaults_to_false(
@@ -248,7 +244,7 @@ def test_handler_passes_all_params(self, rebuild_mock):
         )
 
     @patch(f"{_MODULE}._get_validator_version", return_value="7.0.0")
-    @patch(f"{_MODULE}._filter_datasets_with_existing_blob", return_value=[])
+    @patch(f"{_MODULE}._filter_out_datasets_without_blob", return_value=[])
     @patch(f"{_MODULE}.TaskExecutionTracker")
     def test_default_op_status_filters_published(
         self, tracker_cls, filter_blob_mock, version_mock
@@ -271,7 +267,7 @@ class TestFilterDatasetsWithExistingBlob(unittest.TestCase):
     def test_stops_at_limit(self, storage_mock):
         """Should stop checking GCS as soon as limit valid datasets are found."""
         from tasks.validation_reports.rebuild_missing_validation_reports import (
-            _filter_datasets_with_existing_blob,
+            _filter_out_datasets_without_blob,
         )
 
         bucket_mock = MagicMock()
@@ -283,7 +279,7 @@ def test_stops_at_limit(self, storage_mock):
         bucket_mock.blob.return_value = blob_mock
 
         datasets = [(f"feed-{i}", f"ds-{i}") for i in range(20)]
-        result = _filter_datasets_with_existing_blob(datasets, limit=3)
+        result = _filter_out_datasets_without_blob(datasets, limit=3)
 
         self.assertEqual(len(result), 3)
         # Only 3 GCS calls should have been made
@@ -293,7 +289,7 @@ def test_stops_at_limit(self, storage_mock):
     def test_skips_missing_blobs_and_continues(self, storage_mock):
         """Should skip datasets with no blob and keep going until limit is reached."""
         from tasks.validation_reports.rebuild_missing_validation_reports import (
-            _filter_datasets_with_existing_blob,
+            _filter_out_datasets_without_blob,
         )
 
         bucket_mock = MagicMock()
@@ -306,7 +302,7 @@ def test_skips_missing_blobs_and_continues(self, storage_mock):
         bucket_mock.blob.return_value = blob_mock
 
         datasets = [(f"feed-{i}", f"ds-{i}") for i in range(7)]
-        result = _filter_datasets_with_existing_blob(datasets, limit=3)
+        result = _filter_out_datasets_without_blob(datasets, limit=3)
 
         self.assertEqual(len(result), 3)
         # Must have checked 5 items: 2 missing + 3 valid