fix async issue

Author: davidgamez

functions-python/operations_api/src/feeds_operations/impl/feeds_operations_impl.py

@@ -174,7 +174,7 @@ def handle_get_feeds(
                 status_code=500, detail=f"Internal server error: {str(e)}"
             )
 
-    async def get_feeds(
+    def get_feeds(
         self,
         search_query: Optional[str] = None,
         operation_status: Optional[str] = None,
@@ -189,7 +189,7 @@ async def get_feeds(
         )
 
     @with_db_session
-    async def get_gtfs_feed(
+    def get_gtfs_feed(
         self,
         id: Annotated[
             StrictStr, Field(description="The feed ID of the requested feed.")
@@ -205,7 +205,7 @@ async def get_gtfs_feed(
         return OperationGtfsFeedImpl.from_orm(gtfs_feed)
 
     @with_db_session
-    async def get_gtfs_feed_availability(
+    def get_gtfs_feed_availability(
         self,
         id: Annotated[
             StrictStr, Field(description="The feed ID of the requested feed.")
@@ -249,7 +249,7 @@ async def get_gtfs_feed_availability(
         )
 
     @with_db_session
-    async def get_gtfs_rt_feed(
+    def get_gtfs_rt_feed(
         self,
         id: Annotated[
             StrictStr, Field(description="The feed ID of the requested feed.")

functions-python/operations_api/tests/feeds_operations/impl/test_availability_operations_impl.py

@@ -14,7 +14,7 @@
 async def test_get_gtfs_feed_availability_basic():
     """Returns all availability checks for a known feed."""
     api = OperationsApiImpl()
-    response: GtfsFeedAvailabilityResponse = await api.get_gtfs_feed_availability(
+    response: GtfsFeedAvailabilityResponse = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id, var_from=None, to=None, limit=100, offset=0
     )
     assert response.feed_id == feed_mdb_40.stable_id
@@ -28,7 +28,7 @@ async def test_get_gtfs_feed_availability_basic():
 async def test_get_gtfs_feed_availability_ordered_desc_by_default():
     """Results are ordered from newest to oldest by default."""
     api = OperationsApiImpl()
-    response = await api.get_gtfs_feed_availability(
+    response = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id,
         var_from=None,
         to=None,
@@ -44,7 +44,7 @@ async def test_get_gtfs_feed_availability_ordered_desc_by_default():
 async def test_get_gtfs_feed_availability_ordered_asc():
     """sort=asc returns results from oldest to newest."""
     api = OperationsApiImpl()
-    response = await api.get_gtfs_feed_availability(
+    response = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id,
         var_from=None,
         to=None,
@@ -61,7 +61,7 @@ async def test_get_gtfs_feed_availability_filter_from():
     """Filters checks to those at or after the given from timestamp."""
     api = OperationsApiImpl()
     from_dt = datetime(2025, 3, 1, tzinfo=timezone.utc)
-    response = await api.get_gtfs_feed_availability(
+    response = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id, var_from=from_dt, to=None, limit=100, offset=0
     )
     # Checks on Jan 15 and Feb 10 are excluded; Mar 5, Apr 20, May 1 remain
@@ -74,7 +74,7 @@ async def test_get_gtfs_feed_availability_filter_to():
     """Filters checks to those at or before the given to timestamp."""
     api = OperationsApiImpl()
     to_dt = datetime(2025, 3, 31, tzinfo=timezone.utc)
-    response = await api.get_gtfs_feed_availability(
+    response = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id, var_from=None, to=to_dt, limit=100, offset=0
     )
     # Jan 15, Feb 10, Mar 5 match; Apr 20 and May 1 are excluded
@@ -88,7 +88,7 @@ async def test_get_gtfs_feed_availability_filter_from_to():
     api = OperationsApiImpl()
     from_dt = datetime(2025, 2, 1, tzinfo=timezone.utc)
     to_dt = datetime(2025, 4, 1, tzinfo=timezone.utc)
-    response = await api.get_gtfs_feed_availability(
+    response = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id, var_from=from_dt, to=to_dt, limit=100, offset=0
     )
     # Feb 10 and Mar 5 match; Jan 15, Apr 20, May 1 are excluded
@@ -99,7 +99,7 @@ async def test_get_gtfs_feed_availability_filter_from_to():
 async def test_get_gtfs_feed_availability_pagination():
     """Pagination respects limit and offset; total is always the full count."""
     api = OperationsApiImpl()
-    response = await api.get_gtfs_feed_availability(
+    response = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id, var_from=None, to=None, limit=2, offset=1
     )
     assert response.total == len(availability_checks_mdb_40)
@@ -113,7 +113,7 @@ async def test_get_gtfs_feed_availability_not_found():
     """Returns 404 for an unknown feed ID."""
     api = OperationsApiImpl()
     with pytest.raises(HTTPException) as exc_info:
-        await api.get_gtfs_feed_availability(
+        api.get_gtfs_feed_availability(
             id="mdb-9999", var_from=None, to=None, limit=100, offset=0
         )
     assert exc_info.value.status_code == 404
@@ -123,7 +123,7 @@ async def test_get_gtfs_feed_availability_not_found():
 async def test_get_gtfs_feed_availability_request_method_mapping():
     """http_head maps to HEAD and http_get maps to GET."""
     api = OperationsApiImpl()
-    response = await api.get_gtfs_feed_availability(
+    response = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id, var_from=None, to=None, limit=100, offset=0
     )
     methods = {c.request_method for c in response.checks}
@@ -134,7 +134,7 @@ async def test_get_gtfs_feed_availability_request_method_mapping():
 async def test_get_gtfs_feed_availability_latency_is_float():
     """latency_ms is returned as float, None when not set."""
     api = OperationsApiImpl()
-    response = await api.get_gtfs_feed_availability(
+    response = api.get_gtfs_feed_availability(
         id=feed_mdb_40.stable_id, var_from=None, to=None, limit=100, offset=0
     )
     for check in response.checks:

functions-python/operations_api/tests/feeds_operations/impl/test_get_feeds.py

@@ -28,7 +28,7 @@ async def test_get_feeds_no_filters():
     """
     api = OperationsApiImpl()
 
-    response = await api.get_feeds()
+    response = api.get_feeds()
 
     assert response is not None
     assert response.total == 3
@@ -49,7 +49,7 @@ async def test_get_feeds_gtfs_rt_filter():
     """
     api = OperationsApiImpl()
 
-    response = await api.get_feeds(data_type="gtfs_rt")
+    response = api.get_feeds(data_type="gtfs_rt")
 
     assert response is not None
     assert response.total == 1
@@ -68,7 +68,7 @@ async def test_get_feeds_gtfs_filter():
     """
     api = OperationsApiImpl()
 
-    response = await api.get_feeds(data_type="gtfs")
+    response = api.get_feeds(data_type="gtfs")
 
     assert response is not None
     assert response.total == 2
@@ -86,27 +86,27 @@ async def test_get_feeds_pagination():
     """
     api = OperationsApiImpl()
 
-    response = await api.get_feeds(limit=1)
+    response = api.get_feeds(limit=1)
     assert response.total == 3
     assert response.limit == 1
     assert response.offset == 0
     assert len(response.feeds) == 1
     first_feed = response.feeds[0]
 
-    response = await api.get_feeds(offset=1, limit=1)
+    response = api.get_feeds(offset=1, limit=1)
     assert response.total == 3
     assert response.limit == 1
     assert response.offset == 1
     assert len(response.feeds) == 1
     assert response.feeds[0].stable_id != first_feed.stable_id
 
-    response = await api.get_feeds(offset=3)
+    response = api.get_feeds(offset=3)
     assert response.total == 3
     assert response.limit == 50
     assert response.offset == 3
     assert len(response.feeds) == 0
 
-    response = await api.get_feeds(limit=10)
+    response = api.get_feeds(limit=10)
     assert response.total == 3
     assert response.limit == 10
     assert response.offset == 0
@@ -121,7 +121,7 @@ async def test_get_feeds_operation_status_filter():
     """
     api = OperationsApiImpl()
 
-    base_response = await api.get_feeds()
+    base_response = api.get_feeds()
     assert base_response is not None
 
     feeds_by_status = {}
@@ -133,7 +133,7 @@ async def test_get_feeds_operation_status_filter():
         if status == "none":
             continue
 
-        response = await api.get_feeds(operation_status=status)
+        response = api.get_feeds(operation_status=status)
         assert response is not None
         assert response.total == feeds_by_status[status]
         assert len(response.feeds) == feeds_by_status[status]
@@ -147,24 +147,24 @@ async def test_get_feeds_combined_filters():
     """Test get_feeds with multiple filters applied."""
     api = OperationsApiImpl()
 
-    base_response = await api.get_feeds()
+    base_response = api.get_feeds()
     assert base_response is not None
 
-    gtfs_response = await api.get_feeds(data_type="gtfs")
+    gtfs_response = api.get_feeds(data_type="gtfs")
     assert gtfs_response is not None
 
-    wip_response = await api.get_feeds(operation_status="wip")
+    wip_response = api.get_feeds(operation_status="wip")
     assert wip_response is not None
 
-    response = await api.get_feeds(data_type="gtfs", operation_status="published")
+    response = api.get_feeds(data_type="gtfs", operation_status="published")
     assert response is not None
     wip_gtfs_feeds = response.feeds
 
     assert len(wip_gtfs_feeds) == 1
     assert wip_gtfs_feeds[0].data_type == "gtfs"
     assert wip_gtfs_feeds[0].operational_status == "published"
 
-    response = await api.get_feeds(data_type="gtfs", limit=1, offset=1)
+    response = api.get_feeds(data_type="gtfs", limit=1, offset=1)
     assert response is not None
     assert len(response.feeds) == 1
     assert response.offset == 1
@@ -181,7 +181,7 @@ async def test_get_feeds_unpublished_status():
     api = OperationsApiImpl()
 
     # Test with unpublished status filter
-    response = await api.get_feeds(operation_status="unpublished")
+    response = api.get_feeds(operation_status="unpublished")
     assert response is not None
     for feed in response.feeds:
         assert feed.operational_status == "unpublished"
@@ -197,7 +197,7 @@ async def test_get_feeds_all_operational_statuses():
 
     # Test each operational status
     for status in ["wip", "published", "unpublished"]:
-        response = await api.get_feeds(operation_status=status)
+        response = api.get_feeds(operation_status=status)
         assert response is not None
         for feed in response.feeds:
             assert feed.operational_status == status
@@ -210,17 +210,13 @@ async def test_get_feeds_unpublished_with_data_type():
     """
     api = OperationsApiImpl()
 
-    gtfs_response = await api.get_feeds(
-        operation_status="unpublished", data_type="gtfs"
-    )
+    gtfs_response = api.get_feeds(operation_status="unpublished", data_type="gtfs")
     assert gtfs_response is not None
     for feed in gtfs_response.feeds:
         assert feed.operational_status == "unpublished"
         assert feed.data_type == "gtfs"
 
-    rt_response = await api.get_feeds(
-        operation_status="unpublished", data_type="gtfs_rt"
-    )
+    rt_response = api.get_feeds(operation_status="unpublished", data_type="gtfs_rt")
     assert rt_response is not None
     for feed in rt_response.feeds:
         assert feed.operational_status == "unpublished"
@@ -235,25 +231,25 @@ async def test_get_feeds_search_query():
     """
     api = OperationsApiImpl()
 
-    response = await api.get_feeds(search_query="RT")
+    response = api.get_feeds(search_query="RT")
     assert response is not None
     assert response.total == 1
     assert len(response.feeds) == 1
     assert response.feeds[0].feed_name == "London Transit Commission(RT"
 
-    response = await api.get_feeds(search_query=" Provider B ")
+    response = api.get_feeds(search_query=" Provider B ")
     assert response is not None
     assert response.total == 1
     assert len(response.feeds) == 1
     assert response.feeds[0].provider == "provider B"
 
-    response = await api.get_feeds(search_query="mdb-41")
+    response = api.get_feeds(search_query="mdb-41")
     assert response is not None
     assert response.total == 1
     assert len(response.feeds) == 1
     assert response.feeds[0].stable_id == "mdb-41"
 
-    response = await api.get_feeds(search_query="mdb")
+    response = api.get_feeds(search_query="mdb")
     assert response is not None
     assert response.total == 3
     assert len(response.feeds) == 3