Skip to content

Commit c46450a

Browse files
davidgamezCopilot
andcommitted
chore: remove update_validation_report — superseded by rebuild_missing_validation_reports
The update_validation_report Cloud Function is fully covered by the rebuild_missing_validation_reports task in tasks_executor, which adds: - TaskExecutionTracker integration (idempotent, resumable) - dry_run, limit, filter_after_in_days, filter_op_statuses params - dispatch_complete indicator and Cloud Tasks status sync Removed: - functions-python/update_validation_report/ (entire directory) - Terraform: google_cloudfunctions2_function.update_validation_report - Terraform: google_storage_bucket_object.update_validation_report_zip - Terraform: google_cloud_tasks_queue.update_validation_report_task_queue - Terraform locals: function_update_validation_report_config / _zip - Terraform locals: all_secret_dicts entry for update_validation_report Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent f9ff073 commit c46450a

17 files changed

Lines changed: 14 additions & 499 deletions

File tree

functions-python/helpers/task_execution/task_execution_tracker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# MobilityData 2025
2+
# MobilityData 2026
33
#
44
# Licensed under the Apache License, Version 2.0 (the "License");
55
# you may not use this file except in compliance with the License.

functions-python/helpers/tests/test_task_execution_tracker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# MobilityData 2025
2+
# MobilityData 2026
33
#
44
# Licensed under the Apache License, Version 2.0 (the "License");
55
# you may not use this file except in compliance with the License.

functions-python/tasks_executor/README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,11 @@ Examples:
2020
"task": "rebuild_missing_validation_reports",
2121
"payload": {
2222
"dry_run": true,
23-
"validator_endpoint": "https://stg-gtfs-validator-web-mbzoxaljzq-ue.a.run.app",
2423
"bypass_db_update": true,
24+
"filter_after_in_days": null,
25+
"force_update": false,
26+
"validator_endpoint": "https://stg-gtfs-validator-web-mbzoxaljzq-ue.a.run.app",
27+
"limit": 1,
2528
"filter_statuses": ["active", "inactive", "future"]
2629
}
2730
}
@@ -31,8 +34,8 @@ Examples:
3134
{
3235
"task": "get_validation_run_status",
3336
"payload": {
34-
"validator_version": "7.0.0",
35-
"sync_workflow_status": true
37+
"task_name": "gtfs_validation",
38+
"run_id": "7.1.1-SNAPSHOT"
3639
}
3740
}
3841
```

functions-python/tasks_executor/src/tasks/get_task_run_status.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# MobilityData 2025
2+
# MobilityData 2026
33
#
44
# Licensed under the Apache License, Version 2.0 (the "License");
55
# you may not use this file except in compliance with the License.

functions-python/tasks_executor/src/tasks/sync_task_run_status.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ def sync_task_run_status(
124124
if all_settled:
125125
tracker.finish_run(STATUS_COMPLETED)
126126
db_session.commit()
127+
summary["run_status"] = STATUS_COMPLETED
127128
logging.info(
128129
"sync_task_run_status: run %s/%s complete — task_run marked completed",
129130
task_name,

functions-python/tasks_executor/tests/tasks/test_get_task_run_status.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# MobilityData 2025
2+
# MobilityData 2026
33
#
44
# Licensed under the Apache License, Version 2.0 (the "License");
55
# you may not use this file except in compliance with the License.

functions-python/tasks_executor/tests/tasks/test_sync_task_run_status.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# MobilityData 2025
2+
# MobilityData 2026
33
#
44
# Licensed under the Apache License, Version 2.0 (the "License");
55
# you may not use this file except in compliance with the License.

functions-python/update_validation_report/.coveragerc

Lines changed: 0 additions & 10 deletions
This file was deleted.

functions-python/update_validation_report/.env.rename_me

Lines changed: 0 additions & 7 deletions
This file was deleted.

functions-python/update_validation_report/README.md

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)