Made sure stops with missing coordinates are not written to stops-output.geojson (#1447)

Author: jcpitre

functions-python/pmtiles_builder/src/stops_processor.py

@@ -117,10 +117,6 @@ def add_to_stop_to_coordinates(
         if stop_lon is None or stop_lat is None:
             if is_lat_lon_required(location_type):
                 self.logger.warning("Missing stop latitude and longitude : %s", row)
-            else:
-                self.logger.debug(
-                    "Missing optional stop latitude and longitude : %s", row
-                )
             return
         self.stop_to_coordinates[stop_id] = (stop_lon, stop_lat)
 
@@ -135,15 +131,16 @@ def add_to_stops_geojson(
         stop_url: str = "",
         wheelchair_boarding: str = "",
         location_type: str = "",
-        stop_lon: float = 0.0,
-        stop_lat: float = 0.0,
+        stop_lon: float = None,
+        stop_lat: float = None,
     ) -> None:
         if stop_lon is None or stop_lat is None:
             if is_lat_lon_required(location_type):
                 self.logger.warning(
                     "Missing coordinates for stop_id {%s}, skipping.", stop_id
                 )
-                return
+            # No point in writing a stop-feature if there are missing coordinates.
+            return
 
         route_ids = sorted(self.stop_times_processor.stop_to_routes.get(stop_id, []))
         route_colors = [

functions-python/pmtiles_builder/tests/test_stops_processor.py

@@ -79,14 +79,19 @@ def test_missing_coords_are_skipped(self):
             stops_path = csv_cache.get_path("stops.txt")
 
             with open(stops_path, "w", encoding="utf-8") as f:
-                f.write("stop_id,stop_lon,stop_lat,stop_name\n")
-                # stop without coordinates
-                f.write("stop_missing,,,NoCoords\n")
-                f.write("stop_ok,-73.2,45.2,OK\n")
+                f.write("stop_id,stop_lon,stop_lat,stop_name,location_type\n")
+                # two stops without coordinates: one optional (3), one required (1)
+                f.write("stop_missing_type3,,,Node,3\n")
+                f.write("stop_missing_type1,,,Station,1\n")
+                f.write("stop_ok,-73.2,45.2,OK,0\n")
 
             routes_colors = DummyRoutesProcessorForColors({"r1": "FF0000"})
             stop_times = DummyStopTimesProcessor(
-                {"stop_missing": {"r1"}, "stop_ok": {"r1"}}
+                {
+                    "stop_missing_type3": {"r1"},
+                    "stop_missing_type1": {"r1"},
+                    "stop_ok": {"r1"},
+                }
             )
 
             processor = StopsProcessor(
@@ -108,7 +113,8 @@ def test_missing_coords_are_skipped(self):
             # only stop_ok should be present
             ids = [f.get("properties", {}).get("stop_id") for f in features]
             self.assertIn("stop_ok", ids)
-            self.assertNotIn("stop_missing", ids)
+            self.assertNotIn("stop_missing_type3", ids)
+            self.assertNotIn("stop_missing_type1", ids)
 
 
 if __name__ == "__main__":