Skip to content

bug: fix bug making operations feeds endpoint fail when called without data_type filtering#1157

Merged
davidgamez merged 2 commits intomainfrom
ops_bug_fix
Apr 30, 2025
Merged

bug: fix bug making operations feeds endpoint fail when called without data_type filtering#1157
davidgamez merged 2 commits intomainfrom
ops_bug_fix

Conversation

@AlfredNwolisa
Copy link
Copy Markdown
Contributor

@AlfredNwolisa AlfredNwolisa commented Apr 29, 2025

Summary:

This PR fixes the bug that makes operations feeds endpoint fail when called without data_type filtering. Added a filter to filter out gbfs feeds from the get endpoint

Expected behavior:

Get feeds endpoint can be call without data_type filtering.

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@AlfredNwolisa AlfredNwolisa changed the title Ops bug fix bug: fix bug making operations feeds endpoint fail when called without data_type filtering Apr 29, 2025
@AlfredNwolisa AlfredNwolisa marked this pull request as ready for review April 29, 2025 21:20
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez davidgamez merged commit cc48089 into main Apr 30, 2025
8 of 9 checks passed
@davidgamez davidgamez deleted the ops_bug_fix branch April 30, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operations feeds endpoint fails when called without data_type filtering

3 participants