feat: lighthouse report on frontend PRs by Alessandro100 · Pull Request #1203 · MobilityData/mobility-feed-api

Alessandro100 · 2025-05-15T14:59:41Z

Summary:

Adding lighthouse performance check in frontend PRs

Expected behavior:

On frontend PRs, there should be a lighthouse check on key pages. Also provides the lighthouse report for each key page:

ex: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1748974253255-25918.report.html
This storage url is a temporary url

To Note

the lighthouse report runs once and can be slightly flaky for performance (running many times and averaging out would yield more consistent results but would take more time)
lighthouse has no throttling when running in CI, uses specs of CI machine
IMPORTANT: In this PR there is a lot of different types of reports, but the only one that will persist is the one shown in the screenshot below
Adds ~2 mins to the CI build

Improvements to future versions

Compare performance to production version

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
Add or update any needed documentation to the repo
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

github-actions · 2025-05-15T15:07:58Z

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1203-xjaqi00l.web.app

github-actions

Device	URL
desktop	https://mobilitydatabase.org

Device	URL
mobile	https://mobilitydatabase.org

Device	URL
desktop	https://mobilitydatabase.org/feeds

Device	URL
mobile	https://mobilitydatabase.org/feeds

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

github-actions

Device	URL
desktop	https://mobility-feeds-dev--pr-1203-xjaqi00l.web.app

Device	URL
mobile	https://mobility-feeds-dev--pr-1203-xjaqi00l.web.app

Device	URL
desktop	https://mobility-feeds-dev--pr-1203-xjaqi00l.web.app/feeds

Device	URL
mobile	https://mobility-feeds-dev--pr-1203-xjaqi00l.web.app/feeds

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

github-actions

Device	URL
desktop	http://localhost:55300

Device	URL
mobile	http://localhost:55300

Device	URL
desktop	http://localhost:55300/feeds

Device	URL
mobile	http://localhost:55300/feeds

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

github-actions

Device	URL
desktop	http://localhost:55300

Device	URL
desktop	http://localhost:55300/feeds

Device	URL
desktop	http://localhost:55300/feeds/gtfs/mdb-2126

Device	URL
desktop	http://localhost:55300/feeds/gtfs_rt/mdb-2585

Device	URL
desktop	http://localhost:55300/gbfs/gbfs-flamingo_porirua

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

github-actions · 2025-05-16T13:27:29Z

🔍 Lighthouse Report Results\n

github-actions · 2025-05-16T13:58:37Z

*Lighthouse ran on https://mobility-feeds-dev--pr-1203-nlp6ow3m.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 94	🟢 100	🟢 100	🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1203-nlp6ow3m.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 66	🟠 87	🟢 100	🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1203-nlp6ow3m.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 89	🔴 0	🟢 96	🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1203-nlp6ow3m.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 95	🟠 88	🟢 100	🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1203-nlp6ow3m.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 100	🟢 100	🟢 100	🟢 100

github-actions · 2025-06-03T13:28:06Z

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1203-nlp6ow3m.web.app

davidgamez

Amazing!

davidgamez · 2025-06-03T20:36:04Z

+
+
+      - name: Format lighthouse score
+        id: format_lighthouse_score


do we need: if: ${{ inputs.PREVIEW_DEPLOYMENT }} here?

davidgamez · 2025-06-03T20:36:12Z

+            core.setOutput("comment", finalComment); 
+
+      - name: Add lighthouse comment to PR
+        id: comment_to_pr


do we need: if: ${{ inputs.PREVIEW_DEPLOYMENT }} here?

davidgamez

LGTM! A cool PR!

github-actions Bot reviewed May 15, 2025

View reviewed changes

Alessandro100 force-pushed the winningday/lighthouse-pr-check branch from 6be4156 to c6034bc Compare June 3, 2025 12:42

Alessandro100 added 21 commits June 3, 2025 13:30

test light house github action

d271d07

syntax change

f75cb75

syntax

ee7fedb

syntax

c63cb9b

test

acafdd0

lighthouse check on local build

8d949d3

server contine

5c82a22

syntax

e066b51

seo score adjust

c87481e

flaky test

48e3878

configs

4e2afb2

cleanup

c08b2e8

test

7e3374b

test 2

b496575

fix path

7ea3089

test

ed5f944

test

fcfe847

syntax

c1ca341

format fix

357e2d8

syntax

b8fe475

back to preview url

0e515d6

Alessandro100 added 5 commits June 3, 2025 13:30

throttle

18f3453

syntax

d998b73

t

da65f73

run once + seo accuracy

983dce3

js syntax

f0b1493

Alessandro100 force-pushed the winningday/lighthouse-pr-check branch from 8959c29 to f0b1493 Compare June 3, 2025 17:32

Alessandro100 added 2 commits June 3, 2025 13:43

t

52b557f

cleanup

97c9e0d

Alessandro100 self-assigned this Jun 3, 2025

Alessandro100 changed the title ~~test light house github action~~ feat: lighthouse report on frontend PRs Jun 3, 2025

spacing

421ab49

davidgamez reviewed Jun 3, 2025

View reviewed changes

conditional statments on lighthouse check

8011ea5

Alessandro100 requested a review from davidgamez June 4, 2025 12:43

davidgamez approved these changes Jun 5, 2025

View reviewed changes

Alessandro100 merged commit 963c7a2 into main Jun 6, 2025
6 checks passed

Alessandro100 deleted the winningday/lighthouse-pr-check branch June 6, 2025 13:20

Uh oh!

Conversation

Alessandro100 commented May 15, 2025 • edited by fredericsimard Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To Note

Improvements to future versions

Uh oh!

github-actions Bot commented May 15, 2025

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 16, 2025

🔍 Lighthouse Report Results\n

Uh oh!

github-actions Bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

davidgamez left a comment

Choose a reason for hiding this comment

Uh oh!

davidgamez Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

davidgamez Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

davidgamez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Alessandro100 commented May 15, 2025 •

edited by fredericsimard

Loading

github-actions Bot left a comment •

edited

Loading

github-actions Bot left a comment •

edited

Loading

github-actions Bot left a comment •

edited

Loading

github-actions Bot commented May 16, 2025 •

edited

Loading