chore: improve logs on update tasks functions#1219
Merged
davidgamez merged 4 commits intomainfrom May 27, 2025
Merged
Conversation
Member
Author
|
Log records: |
jcpitre
reviewed
May 27, 2025
| "validator_endpoint": validator_endpoint, | ||
| }, | ||
| } | ||
| logging.info(result) |
Collaborator
There was a problem hiding this comment.
Shouldn't the log give a bit more info, like what is this object it's printing?
Member
Author
There was a problem hiding this comment.
The record contains a "message" field used by GCP as a descriptor:
jcpitre
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Part of #1027
This PR updates the logging calls to the new standardized pattern on the update tasks functions.
Expected behavior:
The Logger class is no longer used in favour of the newly added logging functions.
Testing tips:
This can only be visible in the life environment.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything