feat: Add a Feed Form new conditional fields#1283
Conversation
|
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
|
|
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-knrpecok.web.app/ * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-knrpecok.web.app/feeds * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-knrpecok.web.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-knrpecok.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-knrpecok.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
|
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1283-fspvjzea.web.app |
jcpitre
left a comment
jcpitre
left a comment
There was a problem hiding this comment.
Made sure the new fields appeared when appropriate.
Did not check if the spreadsheet is properly filled with the new fields.
Did not check if the cypress tests worked.
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1283-paiqzchd.web.app |
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1283-knrpecok.web.app |
3 participants
Summary:
Solves #1276 and #1277 by adding new questions and associated Cypress tests.
There was also a broken test according to the linter so I attempted to fix it based on Copilot — feel free to let me know this is totally wrong!
Expected behavior:
#1276 and #1277
Testing tips:
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything