fix: 1308 refresh view cloud task not created when a new dataset is downloaded#1316
Merged
davidgamez merged 29 commits intoAug 14, 2025
Conversation
…n-a-new-dataset-is-downloaded
…n-a-new-dataset-is-downloaded
…aset-is-downloaded' of github.com:MobilityData/mobility-feed-api into 1308-refresh-view-cloud-task-not-created-when-a-new-dataset-is-downloaded
…n-a-new-dataset-is-downloaded
davidgamez
reviewed
Aug 13, 2025
jcpitre
reviewed
Aug 13, 2025
…n-a-new-dataset-is-downloaded
Member
|
@jcpitre @qcdyx I just noticed that a task was created a few days ago in QA with the name "task_name". This is probably due to this code from the previous PR. Let's leave the name of the task blank when no task name is passed. We should also ensure that the other code that creates tasks is not affected by the deduplication mechanism we are introducing. |
…tion is called within create_http_task
davidgamez
deleted the
1308-refresh-view-cloud-task-not-created-when-a-new-dataset-is-downloaded
branch
August 14, 2025 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1308
Expected behavior:
refresh materialized view task is successfully triggered when we trigger batch-datasets function.
Testing tips:
Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything