Skip to content

fix: task name set to none#1319

Merged
davidgamez merged 2 commits into
mainfrom
fix/task_name_none
Aug 15, 2025
Merged

fix: task name set to none#1319
davidgamez merged 2 commits into
mainfrom
fix/task_name_none

Conversation

@davidgamez

@davidgamez davidgamez commented Aug 14, 2025

Copy link
Copy Markdown
Member

Summary:

This pull request ignores the task_name completely when creating an HTTP task. The previous code create a task with ID NONE as shown in the screenshot.

Expected behavior:

The reverse geolocation task is created after a new dataset is downloaded. The GCP infrastructure automatically generates the task ID.

Before the fix:

Screenshot 2025-08-14 at 5 39 33 PM

After the fix:

Screenshot 2025-08-14 at 5 39 18 PM

Testing tips:

[For internal team]:

  • Trigger the batch-datasets-dev function(make sure at least one dataset is downloaded by changing the hash)
  • Wait for the dataset to be downloaded (review logs for errors and warnings)
  • Review the cloud task list in the console.
  • Verify that at least one task is generated with an auto-generated ID

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez
davidgamez marked this pull request as ready for review August 14, 2025 21:47
@davidgamez
davidgamez requested a review from qcdyx August 14, 2025 21:49

@qcdyx qcdyx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me!

@davidgamez
davidgamez merged commit 8a9ed8c into main Aug 15, 2025
2 of 3 checks passed
@davidgamez
davidgamez deleted the fix/task_name_none branch August 15, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants