Skip to content

feat: reduce geojson maps precision and remove ids#1335

Merged
davidgamez merged 2 commits intomainfrom
feat/reduce_map_precision
Sep 5, 2025
Merged

feat: reduce geojson maps precision and remove ids#1335
davidgamez merged 2 commits intomainfrom
feat/reduce_map_precision

Conversation

@davidgamez
Copy link
Copy Markdown
Member

@davidgamez davidgamez commented Sep 3, 2025

Summary:

Part of MobilityData/product-tasks#152

Changes

  • Reduce precision in geojson files to 5 decimals
  • Remove osm_id from geojson exported file and UI maps

Out of Scope

  • Apply changes to already generated geolocation files

Expected behavior:

OSM ID is not exposed.

Screenshot 2025-09-04 at 5 09 17 PM

Testing tips:

Geojson IDs

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez davidgamez changed the title reduce geojson maps precision and remove osm id feat: reduce geojson maps precision and remove osm ids Sep 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2025

*Lighthouse ran on https://mobility-feeds-dev--pr-1335-cwkq1jfx.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 75 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1335-cwkq1jfx.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 84 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1335-cwkq1jfx.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 90 🔴 0 🟢 96 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1335-cwkq1jfx.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 91 🟠 88 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1335-cwkq1jfx.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 100 🟢 100 🟢 100 🟢 100

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2025

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1335-cwkq1jfx.web.app

@davidgamez davidgamez marked this pull request as ready for review September 4, 2025 21:10
@davidgamez davidgamez changed the title feat: reduce geojson maps precision and remove osm ids feat: reduce geojson maps precision and remove ids Sep 4, 2025
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez davidgamez merged commit a609176 into main Sep 5, 2025
12 checks passed
@davidgamez davidgamez deleted the feat/reduce_map_precision branch September 5, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants