Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality for batch filling PMTiles visualization files. The changes enable the automated rebuilding of missing visualization files (PMTiles) for GTFS datasets by implementing a new task system and moving PMTiles builder functionality to shared helpers.
Key changes:
- Added infrastructure for PMTiles builder task queue and IAM permissions
- Implemented a new task executor function to rebuild missing visualization files with comprehensive testing
- Refactored PMTiles builder functionality from batch processing to shared helpers for reusability
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| infra/functions-python/main.tf | Added task queue infrastructure and IAM permissions for PMTiles builder batch processing |
| functions-python/tasks_executor/src/tasks/visualization_files/rebuild_missing_visualization_files.py | New task implementation to identify and rebuild missing PMTiles visualization files |
| functions-python/tasks_executor/tests/tasks/vizualisation_files/test_rebuild_visualization_files.py | Comprehensive test suite for the visualization files rebuild functionality |
| functions-python/tasks_executor/src/tasks/visualization_files/README.md | Documentation for the new visualization files rebuild task |
| functions-python/tasks_executor/src/main.py | Added new task handler registration for visualization files rebuilding |
| functions-python/helpers/utils.py | Moved PMTiles builder task creation function to shared helpers |
| functions-python/helpers/tests/test_helpers.py | Added tests for the moved PMTiles builder function |
| functions-python/batch_process_dataset/tests/test_pipeline_tasks.py | Removed PMTiles builder tests (moved to helpers) |
| functions-python/batch_process_dataset/src/pipeline_tasks.py | Refactored to use shared PMTiles builder function |
| functions-python/batch_process_dataset/src/main.py | Updated DatasetProcessor methods and improved error handling |
| functions-python/batch_process_dataset/tests/test_batch_process_dataset_main.py | Updated tests to reflect method name changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cka-y
marked this pull request as ready for review
September 3, 2025 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces improvements and refactorings to dataset processing and pipeline task creation, especially around handling PMTiles builder tasks and visualization files.
The changes include:
Testing tips:
Test in dev by calling:
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything