Skip to content

feat: update feed geolocation information#1361

Merged
davidgamez merged 6 commits into
mainfrom
feat/update_geolocation_feed_info
Sep 16, 2025
Merged

feat: update feed geolocation information#1361
davidgamez merged 6 commits into
mainfrom
feat/update_geolocation_feed_info

Conversation

@davidgamez

@davidgamez davidgamez commented Sep 15, 2025

Copy link
Copy Markdown
Member

Summary:

In #1353 we introduced feed. geolocation_file_created_date and feed. geolocation_file_dataset_id fields to track the generation og the geolocation files per feed. All current feeds were updated with the information as part of #1353 issue. In this PR, we are updating the geolocation generation to persist those fields for the new added datasets.

Expected behavior:
The feed. geolocation_file_created_dateandfeed. geolocation_file_dataset_id` fields are populated as part of the location extraction process.

Testing tips:
This can tested in local using the reverse_geolocation_process_verifier.py.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez davidgamez changed the title update feed geolocation information feat: update feed geolocation information Sep 16, 2025
@davidgamez
davidgamez marked this pull request as ready for review September 16, 2025 17:38
Comment thread functions-python/reverse_geolocation/tests/test_reverse_geolocation_processor.py Outdated
Comment thread liquibase/changes/feat_fix_geolocation_circular_dep.sql

@cka-y cka-y left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez
davidgamez merged commit d1843a6 into main Sep 16, 2025
2 of 3 checks passed
@davidgamez
davidgamez deleted the feat/update_geolocation_feed_info branch September 16, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants